Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/browser_watcher/window_hang_monitor_win_unittest.cc

Issue 2950153002: Improve process launch handle sharing API. (Closed)
Patch Set: Fix Mojo launcher, review comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/installer/util/user_experiment.cc ('K') | « components/browser_watcher/watcher_client_win_unittest.cc ('k') | components/crash/content/browser/crash_dump_manager_android.h » ('j') | mojo/edk/test/multiprocess_test_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/window_hang_monitor_win_unittest.cc
diff --git a/components/browser_watcher/window_hang_monitor_win_unittest.cc b/components/browser_watcher/window_hang_monitor_win_unittest.cc
index 2df2a7b5a1c6d970ca48d8d75a083eb375ae84a2..99026b12055525c5ef3a57e92306d4a6656f766a 100644
--- a/components/browser_watcher/window_hang_monitor_win_unittest.cc
+++ b/components/browser_watcher/window_hang_monitor_win_unittest.cc
@@ -362,7 +362,7 @@ class WindowHangMonitorTest : public testing::Test {
AppendSwitchHandle(&command_line, kChildWritePipeSwitch, child_write_pipe);
base::LaunchOptions options = {};
- options.inherit_handles = true;
+ options.inherit_mode = base::LaunchOptions::Inherit::kAll;
jschuh 2017/07/24 19:41:27 Leave a TODO here.
monitored_process_ = base::LaunchProcess(command_line, options);
if (!monitored_process_.IsValid())
return false;
« chrome/installer/util/user_experiment.cc ('K') | « components/browser_watcher/watcher_client_win_unittest.cc ('k') | components/crash/content/browser/crash_dump_manager_android.h » ('j') | mojo/edk/test/multiprocess_test_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698