Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2950113003: [Refactor] Remove AppBannerManager::app_title_ (Closed)

Created:
3 years, 6 months ago by pkotwicz
Modified:
3 years, 5 months ago
Reviewers:
dominickn
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Refactor] Remove AppBannerManager::app_title_ This CL removes AppBannerManager::app_title_ in favor of a native app dedicated variable BUG=728300 Review-Url: https://codereview.chromium.org/2950113003 Cr-Commit-Position: refs/heads/master@{#482505} Committed: https://chromium.googlesource.com/chromium/src/+/41ffd85bd01d941f109ce9f8e94f098834dcf29b

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into same_infobar_title0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M chrome/browser/android/banners/app_banner_manager_android.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/android/banners/app_banner_manager_android.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/banners/app_banner_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/banners/app_banner_manager.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
pkotwicz
Dominick, can you please take a look? This is a subset of https://codereview.chromium.org/2915913002/ I will ...
3 years, 6 months ago (2017-06-21 21:56:25 UTC) #2
dominickn
On 2017/06/21 21:56:25, pkotwicz wrote: > Dominick, can you please take a look? > > ...
3 years, 6 months ago (2017-06-22 02:39:53 UTC) #3
dominickn
lgtm, thanks for bearing with me!
3 years, 6 months ago (2017-06-23 01:14:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950113003/1
3 years, 6 months ago (2017-06-23 03:39:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/295031)
3 years, 6 months ago (2017-06-23 03:52:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950113003/20001
3 years, 6 months ago (2017-06-23 19:34:10 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/324500)
3 years, 6 months ago (2017-06-23 21:23:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950113003/20001
3 years, 5 months ago (2017-06-26 23:48:42 UTC) #15
commit-bot: I haz the power
3 years, 5 months ago (2017-06-27 01:34:14 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/41ffd85bd01d941f109ce9f8e94f...

Powered by Google App Engine
This is Rietveld 408576698