Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: chrome/browser/banners/app_banner_manager.h

Issue 2950113003: [Refactor] Remove AppBannerManager::app_title_ (Closed)
Patch Set: Merge branch 'master' into same_infobar_title0 Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_ 5 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
6 #define CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_ 6 #define CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 return false; 234 return false;
235 } 235 }
236 bool is_complete() const { return state_ == State::COMPLETE; } 236 bool is_complete() const { return state_ == State::COMPLETE; }
237 bool is_pending_engagement() const { 237 bool is_pending_engagement() const {
238 return state_ == State::PENDING_ENGAGEMENT; 238 return state_ == State::PENDING_ENGAGEMENT;
239 } 239 }
240 bool is_pending_event() const { 240 bool is_pending_event() const {
241 return state_ == State::PENDING_EVENT || page_requested_prompt_; 241 return state_ == State::PENDING_EVENT || page_requested_prompt_;
242 } 242 }
243 243
244 // The title to display in the banner.
245 base::string16 app_title_;
246
247 // The URL for which the banner check is being conducted. 244 // The URL for which the banner check is being conducted.
248 GURL validated_url_; 245 GURL validated_url_;
249 246
250 // The URL of the manifest. 247 // The URL of the manifest.
251 GURL manifest_url_; 248 GURL manifest_url_;
252 249
253 // The manifest object. 250 // The manifest object.
254 content::Manifest manifest_; 251 content::Manifest manifest_;
255 252
256 // The URL of the primary icon. 253 // The URL of the primary icon.
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
323 // scoped to the WebContents which they are observing. This allows us to use 320 // scoped to the WebContents which they are observing. This allows us to use
324 // weak pointers for callbacks. 321 // weak pointers for callbacks.
325 base::WeakPtrFactory<AppBannerManager> weak_factory_; 322 base::WeakPtrFactory<AppBannerManager> weak_factory_;
326 323
327 DISALLOW_COPY_AND_ASSIGN(AppBannerManager); 324 DISALLOW_COPY_AND_ASSIGN(AppBannerManager);
328 }; 325 };
329 326
330 } // namespace banners 327 } // namespace banners
331 328
332 #endif // CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_ 329 #endif // CHROME_BROWSER_BANNERS_APP_BANNER_MANAGER_H_
OLDNEW
« no previous file with comments | « chrome/browser/android/banners/app_banner_manager_android.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698