Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2950003002: Roll v8 isolate binaries to match the chromium versions. (Closed)

Created:
3 years, 6 months ago by mcgreevy
Modified:
3 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Roll v8 isolate binaries to match the chromium versions. The chromium versions were rolled here: https://codereview.chromium.org/2949663002/ BUG=chromium:692940 Review-Url: https://codereview.chromium.org/2950003002 Cr-Commit-Position: refs/heads/master@{#46081} Committed: https://chromium.googlesource.com/v8/v8/+/25f86761e6c1db913d90d8e2fe321731601bef0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/luci-go/linux64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/mac64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/win64/isolate.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
mcgreevy
On 2017/06/21 01:41:39, mcgreevy wrote: > mailto:mcgreevy@chromium.org changed reviewers: > + mailto:tandrii@chromium.org I'm sending this ...
3 years, 6 months ago (2017-06-21 01:42:43 UTC) #3
tandrii(chromium)
lgtm
3 years, 6 months ago (2017-06-21 09:37:31 UTC) #4
Michael Achenbach
lgtm lgtm, I deleted some comments in the description that aren't really necessary in the ...
3 years, 6 months ago (2017-06-21 09:39:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950003002/1
3 years, 6 months ago (2017-06-21 09:39:42 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/43556)
3 years, 6 months ago (2017-06-21 09:44:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950003002/1
3 years, 6 months ago (2017-06-21 09:48:01 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 12:15:46 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/25f86761e6c1db913d90d8e2fe321731601...

Powered by Google App Engine
This is Rietveld 408576698