Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2645053002: Roll isolate binaries generated at infra@9249eb0 (Closed)

Created:
3 years, 11 months ago by Michael Achenbach
Modified:
3 years, 11 months ago
Reviewers:
M-A Ruel
CC:
v8-reviews_googlegroups.com, mcgreevy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Roll isolate binaries generated at infra@9249eb0 TBR=maruel@chromium.org BUG=v8:5872 Review-Url: https://codereview.chromium.org/2645053002 Cr-Commit-Position: refs/heads/master@{#42558} Committed: https://chromium.googlesource.com/v8/v8/+/77d08c13471829e461db56ee8fc8cf4139ac6f49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/luci-go/linux64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/mac64/isolate.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/luci-go/win64/isolate.exe.sha1 View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Michael Achenbach
TBR
3 years, 11 months ago (2017-01-20 13:04:44 UTC) #2
Michael Achenbach
TBR
3 years, 11 months ago (2017-01-20 13:04:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645053002/1
3 years, 11 months ago (2017-01-20 13:04:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/77d08c13471829e461db56ee8fc8cf4139ac6f49
3 years, 11 months ago (2017-01-20 13:36:02 UTC) #8
M-A Ruel
lgtm but make sure to coordinate with Michael since he's the one doing rolls now. ...
3 years, 11 months ago (2017-01-20 14:53:55 UTC) #9
Michael Achenbach
3 years, 11 months ago (2017-01-20 15:01:45 UTC) #10
Message was sent while issue was closed.
On 2017/01/20 14:53:55, M-A Ruel wrote:
> lgtm but make sure to coordinate with Michael since he's the one doing rolls
> now. He did one 12 hours ago in https://codereview.chromium.org/2646873003/

That's the version I rolled to now. I think I should find a way to add this to
our auto-rollers... to always match chromium's version.

Powered by Google App Engine
This is Rietveld 408576698