Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2949953002: Make LockImpl::Unlock available for inlining (Closed)

Created:
3 years, 6 months ago by hans
Modified:
3 years, 6 months ago
Reviewers:
gab, Nico
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make LockImpl::Unlock available for inlining This function is hit frequently and we'd like it to available for inlining even in non-LTO builds (see bug). BUG=728324 Review-Url: https://codereview.chromium.org/2949953002 Cr-Commit-Position: refs/heads/master@{#481090} Committed: https://chromium.googlesource.com/chromium/src/+/73f022ae44572601cb364871eaba46088c3c2666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M base/synchronization/lock_impl.h View 4 chunks +15 lines, -2 lines 0 comments Download
M base/synchronization/lock_impl_posix.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M base/synchronization/lock_impl_win.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
hans
Please take a look. I wanted to do ::Lock as well, but it's complicated due ...
3 years, 6 months ago (2017-06-20 23:32:45 UTC) #2
Nico
lgtm
3 years, 6 months ago (2017-06-21 00:57:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949953002/1
3 years, 6 months ago (2017-06-21 00:58:50 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 02:34:32 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/73f022ae44572601cb364871eaba...

Powered by Google App Engine
This is Rietveld 408576698