Make LockImpl::Unlock available for inlining

base/synchronization/lock_impl_posix.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/synchronization/lock_impl.h"
 
-#include <errno.h>
 #include <string.h>
 
 #include "base/debug/activity_tracker.h"
-#include "base/logging.h"
 #include "base/synchronization/lock.h"
 
 namespace base {
 namespace internal {
 
 // Determines which platforms can consider using priority inheritance locks. Use
 // this define for platform code that may not compile if priority inheritance
 // locks aren't available. For this platform code,
 // PRIORITY_INHERITANCE_LOCKS_POSSIBLE() is a necessary but insufficient check.
 // Lock::PriorityInheritanceAvailable still must be checked as the code may
@@ skipping 36 matching lines @@
   DCHECK(rv == 0 || rv == EBUSY) << ". " << strerror(rv);
   return rv == 0;
 }
 
 void LockImpl::Lock() {
   base::debug::ScopedLockAcquireActivity lock_activity(this);
   int rv = pthread_mutex_lock(&native_handle_);
   DCHECK_EQ(rv, 0) << ". " << strerror(rv);
 }
 
-void LockImpl::Unlock() {
-  int rv = pthread_mutex_unlock(&native_handle_);
-  DCHECK_EQ(rv, 0) << ". " << strerror(rv);
-}
-
 // static
 bool LockImpl::PriorityInheritanceAvailable() {
 #if PRIORITY_INHERITANCE_LOCKS_POSSIBLE() && defined(OS_MACOSX)
   return true;
 #else
   // Security concerns prevent the use of priority inheritance mutexes on Linux.
   //   * CVE-2010-0622 - wake_futex_pi unlocks incorrect, possible DoS.
   //     https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2010-0622
   //   * CVE-2012-6647 - Linux < 3.5.1, futex_wait_requeue_pi possible DoS.
   //     https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2012-6647
   //   * CVE-2014-3153 - Linux <= 3.14.5, futex_requeue, privilege escalation.
   //     https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2014-3153
   //
   // If the above were all addressed, we still need a runtime check to deal with
   // the bug below.
   //   * glibc Bug 14652: https://sourceware.org/bugzilla/show_bug.cgi?id=14652
   //     Fixed in glibc 2.17.
   //     Priority inheritance mutexes may deadlock with condition variables
   //     during recacquisition of the mutex after the condition variable is
   //     signalled.
   return false;
 #endif
 }
 
 }  // namespace internal
 }  // namespace base