Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2949923004: Reland: [Sync] Record sync memory usage in histogram broken by datatypes (Closed)

Created:
3 years, 6 months ago by pavely
Modified:
3 years, 6 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: [Sync] Record sync memory usage in histogram broken by datatypes Memory estimate is collected from Directory for directory based datatypes and from SharedModelTypeProcessor for USS datatypes. It is triggered right after configuration when all sync data is loaded into memory. BUG=706214 R=pnoland@chromium.org TBR=isherman@chromium.org This is a reland of http://crrev.com/2950583003. Review-Url: https://codereview.chromium.org/2949923004 Cr-Commit-Position: refs/heads/master@{#481400} Committed: https://chromium.googlesource.com/chromium/src/+/df8bde78e96e636afd883deea1fb7e0752a78599

Patch Set 1 : Original CL #

Patch Set 2 : Fix linker error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -4 lines) Patch
M components/browser_sync/profile_sync_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/browser_sync/profile_sync_service.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M components/sync/base/data_type_histogram.h View 1 chunk +9 lines, -0 lines 0 comments Download
M components/sync/base/data_type_histogram.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M components/sync/driver/data_type_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/sync/driver/directory_data_type_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/driver/directory_data_type_controller.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M components/sync/driver/model_type_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/driver/model_type_controller.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M components/sync/driver/proxy_data_type_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/driver/proxy_data_type_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync/model/model_type_debug_info.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/sync/model/model_type_debug_info.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M components/sync/protocol/proto_memory_estimations.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/sync/syncable/directory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/sync/syncable/directory.cc View 2 chunks +39 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
pavely
This is a reland of http://crrev.com/2950583003. There are no histogram related changes thus isherman@ TBR.
3 years, 6 months ago (2017-06-21 17:28:39 UTC) #1
Patrick Noland
lgtm
3 years, 6 months ago (2017-06-21 23:39:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949923004/20001
3 years, 6 months ago (2017-06-22 00:47:26 UTC) #8
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 01:56:51 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/df8bde78e96e636afd883deea1fb...

Powered by Google App Engine
This is Rietveld 408576698