components/sync/driver/data_type_controller.h - Issue 2949923004: Reland: [Sync] Record sync memory usage in histogram broken by datatypes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/driver/data_type_controller.h

Issue 2949923004: Reland: [Sync] Record sync memory usage in histogram broken by datatypes (Closed)

Patch Set: Fix linker error Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/driver/data_type_controller.h

diff --git a/components/sync/driver/data_type_controller.h b/components/sync/driver/data_type_controller.h

index 7f9aecc5a400aea6110cbb08324f52ebb587fa58..8fd7bd83067410ccec3dd26644e90ef3ec7104b8 100644

--- a/components/sync/driver/data_type_controller.h

+++ b/components/sync/driver/data_type_controller.h

@@ -162,6 +162,9 @@ class DataTypeController : public base::SupportsWeakPtr<DataTypeController> {

// Used to display entity counts in chrome://sync-internals.

virtual void GetStatusCounters(const StatusCountersCallback& callback) = 0;

+ // Estimates memory usage of type and records it into histogram.

+ virtual void RecordMemoryUsageHistogram() = 0;

protected:

explicit DataTypeController(ModelType type);