[Payment Request] Formats phone number and credit card number in editors.

ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm

Index: ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
diff --git a/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm b/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
index bd63f8cabd38ebb8934a76f649b429aa6bab6bb3..7b4624fc7afd0e70b42a78ce76c0528d86f267a9 100644
--- a/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
+++ b/ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
@@ -384,7 +384,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
 }
 
 // This method is called as the text is being typed in, pasted, or deleted. Asks
-// the delegate if the text should be changed. Should always return YES. During
+// the delegate if the text should be changed. Should always return NO. During
 // typing/pasting text, |newText| contains one or more new characters. When user
 // deletes text, |newText| is empty. |range| is the range of characters to be
 // replaced.
@@ -401,24 +401,31 @@ typedef NS_ENUM(NSInteger, ItemType) {
   AutofillEditItem* item = base::mac::ObjCCastStrict<AutofillEditItem>(
       [model itemAtIndexPath:indexPath]);
 
-  // Find the respective editor field and update its value.
+  // Find the respective editor field and update its value to the proposed text.
   NSNumber* key = [NSNumber numberWithInt:sectionIdentifier];
   EditorField* field = self.fieldsMap[key];
   DCHECK(field);
-  // Obtain the text being typed.
-  NSString* updatedText =
-      [textField.text stringByReplacingCharactersInRange:range
-                                              withString:newText];
-  field.value = updatedText;
+  field.value = [textField.text stringByReplacingCharactersInRange:range
+                                                        withString:newText];
+
+  // Format the proposed text if necessary.
+  [_dataSource formatValueForEditorField:field];
+
+  // Since this method is returning NO, update the text field's value now.
+  dispatch_async(dispatch_get_main_queue(), ^{

[lpromero, 2017/06/20 16:37:49]

It is not clear to me why this is doing.

[Moe, 2017/06/20 18:00:59]

I was experiencing a jumping effect with the cursor in the text field as I was
typing. I though the reason was that the text is being changed, as the user is
typing. Adding the async call eliminated that effect. However, I'm not able to
recreate it now. Perhaps something else was causing it? Removing this until we
observe a problem.

+    textField.text = field.value;
+  });
 
   // Get the icon that identifies the field value and reload the cell if the
   // icon changes.
   UIImage* oldIcon = item.identifyingIcon;
   item.identifyingIcon = [_dataSource iconIdentifyingEditorField:field];
-  if (item.identifyingIcon != oldIcon)
+  if (item.identifyingIcon != oldIcon) {
+    item.textFieldValue = field.value;
     [self reconfigureCellsForItems:@[ item ]];
+  }
 
-  return YES;
+  return NO;
 }
 
 #pragma mark - AutofillEditAccessoryDelegate