[Payment Request] Formats phone number and credit card number in editors.

ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/payments/payment_request_edit_view_controller.h"
 
 #include "base/logging.h"
 #import "base/mac/foundation_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "components/strings/grit/components_strings.h"
@@ skipping 366 matching lines @@
   AutofillEditCell* nextCell = [self nextTextFieldWithOffset:1];
   if (nextCell)
     [self nextPressed];
   else
     [self closePressed];
 
   return NO;
 }
 
 // This method is called as the text is being typed in, pasted, or deleted. Asks
-// the delegate if the text should be changed. Should always return YES. During
+// the delegate if the text should be changed. Should always return NO. During
 // typing/pasting text, |newText| contains one or more new characters. When user
 // deletes text, |newText| is empty. |range| is the range of characters to be
 // replaced.
 - (BOOL)textField:(UITextField*)textField
     shouldChangeCharactersInRange:(NSRange)range
                 replacementString:(NSString*)newText {
   CollectionViewModel* model = self.collectionViewModel;
 
   DCHECK(_currentEditingCell == AutofillEditCellForTextField(textField));
 
   NSIndexPath* indexPath = [self indexPathForCurrentTextField];
   NSInteger sectionIdentifier =
       [model sectionIdentifierForSection:[indexPath section]];
   AutofillEditItem* item = base::mac::ObjCCastStrict<AutofillEditItem>(
       [model itemAtIndexPath:indexPath]);
 
-  // Find the respective editor field and update its value.
+  // Find the respective editor field and update its value to the proposed text.
   NSNumber* key = [NSNumber numberWithInt:sectionIdentifier];
   EditorField* field = self.fieldsMap[key];
   DCHECK(field);
-  // Obtain the text being typed.
-  NSString* updatedText =
-      [textField.text stringByReplacingCharactersInRange:range
-                                              withString:newText];
-  field.value = updatedText;
+  field.value = [textField.text stringByReplacingCharactersInRange:range
+                                                        withString:newText];
+
+  // Format the proposed text if necessary.
+  [_dataSource formatValueForEditorField:field];
+
+  // Since this method is returning NO, update the text field's value now.
+  dispatch_async(dispatch_get_main_queue(), ^{

[lpromero, 2017/06/20 16:37:49]

It is not clear to me why this is doing.

[Moe, 2017/06/20 18:00:59]

I was experiencing a jumping effect with the cursor in the text field as I was
typing. I though the reason was that the text is being changed, as the user is
typing. Adding the async call eliminated that effect. However, I'm not able to
recreate it now. Perhaps something else was causing it? Removing this until we
observe a problem.

+    textField.text = field.value;
+  });
 
   // Get the icon that identifies the field value and reload the cell if the
   // icon changes.
   UIImage* oldIcon = item.identifyingIcon;
   item.identifyingIcon = [_dataSource iconIdentifyingEditorField:field];
-  if (item.identifyingIcon != oldIcon)
+  if (item.identifyingIcon != oldIcon) {
+    item.textFieldValue = field.value;
     [self reconfigureCellsForItems:@[ item ]];
+  }
 
-  return YES;
+  return NO;
 }
 
 #pragma mark - AutofillEditAccessoryDelegate
 
 - (void)nextPressed {
   AutofillEditCell* nextCell = [self nextTextFieldWithOffset:1];
   if (nextCell)
     [nextCell.textField becomeFirstResponder];
 }
 
@@ skipping 300 matching lines @@
   [_currentEditingCell.textField resignFirstResponder];
 
   if (![self validateForm])
     return;
 
   [self.delegate paymentRequestEditViewController:self
                            didFinishEditingFields:self.fields];
 }
 
 @end