[Payment Request] Formats phone number and credit card number in editors.

[Payment Request] Formats phone number and credit card number in editors.

card number: http://imgur.com/a/ffyCF, http://imgur.com/a/pMl33
phone number: http://imgur.com/a/H7i6b, http://imgur.com/a/HpHto

BUG=602666
Review-Url: https://codereview.chromium.org/2949813003
Cr-Commit-Position: refs/heads/master@{#481246}
Committed: https://chromium.googlesource.com/chromium/src/+/8f116dbbd9f73e7d14c7f3276c0687cd3709761d

[Moe, 2017-06-20 16:08:38]

Description was changed from

==========
[Payment Request] Formats phone number and credit card number in editors.

BUG=602666
==========

to

==========
[Payment Request] Formats phone number and credit card number in editors.

card number: http://imgur.com/a/mkxub
phone number: http://imgur.com/a/H7i6b

BUG=602666
==========

[Moe, 2017-06-20 16:09:36]

mahmadi@chromium.org changed reviewers:
+ lpromero@chromium.org, rouslan@chromium.org

[Moe, 2017-06-20 16:09:36]

Hi Rouslan, Louis, Please take a look at this.

lpromero@ ios/
rouslan@ components/payments and c/b/ui/views/payments

[please use gerrit instead, 2017-06-20 16:22:22]

Both gifs seem to show phone number formatting.

[please use gerrit instead, 2017-06-20 16:27:04]

When you edit an existing address, is the phone pre-formatted in the input
field? Same question for CC.

https://codereview.chromium.org/2949813003/diff/1/components/payments/core/pa...
File components/payments/core/payment_request_data_util.cc (right):

https://codereview.chromium.org/2949813003/diff/1/components/payments/core/pa...
components/payments/core/payment_request_data_util.cc:196: // Do not format
masked card numbers, which start with a letter.
Move this comment into the header file.

[lpromero, 2017-06-20 16:37:49]

https://codereview.chromium.org/2949813003/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
(right):

https://codereview.chromium.org/2949813003/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm:415:
dispatch_async(dispatch_get_main_queue(), ^{
It is not clear to me why this is doing.

[Moe, 2017-06-20 17:45:54]

Description was changed from

==========
[Payment Request] Formats phone number and credit card number in editors.

card number: http://imgur.com/a/mkxub
phone number: http://imgur.com/a/H7i6b

BUG=602666
==========

to

==========
[Payment Request] Formats phone number and credit card number in editors.

card number: http://imgur.com/a/ffyCF
phone number: http://imgur.com/a/H7i6b

BUG=602666
==========

[Moe, 2017-06-20 17:54:58]

Description was changed from

==========
[Payment Request] Formats phone number and credit card number in editors.

card number: http://imgur.com/a/ffyCF
phone number: http://imgur.com/a/H7i6b

BUG=602666
==========

to

==========
[Payment Request] Formats phone number and credit card number in editors.

card number: http://imgur.com/a/ffyCF, http://imgur.com/a/pMl33
phone number: http://imgur.com/a/H7i6b, http://imgur.com/a/HpHto

BUG=602666
==========

[Moe, 2017-06-20 18:00:59]

Updated the gifs as well. PTAL?

https://codereview.chromium.org/2949813003/diff/1/components/payments/core/pa...
File components/payments/core/payment_request_data_util.cc (right):

https://codereview.chromium.org/2949813003/diff/1/components/payments/core/pa...
components/payments/core/payment_request_data_util.cc:196: // Do not format
masked card numbers, which start with a letter.
On 2017/06/20 at 16:27:04, rouslan wrote:
> Move this comment into the header file.

Done.

https://codereview.chromium.org/2949813003/diff/1/ios/chrome/browser/ui/payme...
File ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm
(right):

https://codereview.chromium.org/2949813003/diff/1/ios/chrome/browser/ui/payme...
ios/chrome/browser/ui/payments/payment_request_edit_view_controller.mm:415:
dispatch_async(dispatch_get_main_queue(), ^{
On 2017/06/20 at 16:37:49, lpromero wrote:
> It is not clear to me why this is doing.

I was experiencing a jumping effect with the cursor in the text field as I was
typing. I though the reason was that the text is being changed, as the user is
typing. Adding the async call eliminated that effect. However, I'm not able to
recreate it now. Perhaps something else was causing it? Removing this until we
observe a problem.

[please use gerrit instead, 2017-06-20 18:09:57]

Payments LGTM.

[lpromero, 2017-06-21 08:52:51]

lgtm

[Moe, 2017-06-21 13:07:21]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-06-21 13:07:22]

Thank you!

[commit-bot: I haz the power, 2017-06-21 13:07:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 13:45:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 13:45:05]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Moe, 2017-06-21 16:03:24]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-06-21 16:03:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2949813003/#ps40001
(title: "Fixed broken tests")

[commit-bot: I haz the power, 2017-06-21 16:03:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 18:20:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498061004110330,
"parent_rev": "7f0a1bec9341c8ec61e143c8742cd4ae27cf09f2", "commit_rev":
"8f116dbbd9f73e7d14c7f3276c0687cd3709761d"}

[commit-bot: I haz the power, 2017-06-21 18:20:47]

Description was changed from

==========
[Payment Request] Formats phone number and credit card number in editors.

card number: http://imgur.com/a/ffyCF, http://imgur.com/a/pMl33
phone number: http://imgur.com/a/H7i6b, http://imgur.com/a/HpHto

BUG=602666
==========

to

==========
[Payment Request] Formats phone number and credit card number in editors.

card number: http://imgur.com/a/ffyCF, http://imgur.com/a/pMl33
phone number: http://imgur.com/a/H7i6b, http://imgur.com/a/HpHto

BUG=602666

Review-Url: https://codereview.chromium.org/2949813003
Cr-Commit-Position: refs/heads/master@{#481246}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f116dbbd9f73e7d14c7f3276c06...
==========

[commit-bot: I haz the power, 2017-06-21 18:20:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8f116dbbd9f73e7d14c7f3276c06...