Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2949633002: Do not tie cleanup tool download to SRTPromptFieldTrial field trial (Closed)

Created:
3 years, 6 months ago by veranika
Modified:
3 years, 6 months ago
Reviewers:
csharp
CC:
chromium-reviews, vakh+watch_chromium.org, joenotcharles+watch_chromium.org, grt+watch_chromium.org, timvolodine, csharp+watch_chromium.org, alito+watch_chromium.org, ftirelo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not tie cleanup tool download to SRTPromptFieldTrial field trial BUG=733358 R=csharp@chromium.org Review-Url: https://codereview.chromium.org/2949633002 Cr-Commit-Position: refs/heads/master@{#481214} Committed: https://chromium.googlesource.com/chromium/src/+/5e77d8045bc6904a6925dced1187f3e7dd8d5ae2

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use newer API #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc View 1 3 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win_unittest.cc View 1 chunk +14 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
veranika
3 years, 6 months ago (2017-06-19 20:28:45 UTC) #1
csharp
lgtm https://codereview.chromium.org/2949633002/diff/1/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc File chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc (right): https://codereview.chromium.org/2949633002/diff/1/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc#newcode77 chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc:77: variations::GetVariationParamValueByFeature(kCleanerDownloadFeature, This version seems to be deprecated now, ...
3 years, 6 months ago (2017-06-21 08:36:24 UTC) #2
veranika
https://codereview.chromium.org/2949633002/diff/1/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc File chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc (right): https://codereview.chromium.org/2949633002/diff/1/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc#newcode77 chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc:77: variations::GetVariationParamValueByFeature(kCleanerDownloadFeature, On 2017/06/21 08:36:24, csharp wrote: > This version ...
3 years, 6 months ago (2017-06-21 14:55:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949633002/20001
3 years, 6 months ago (2017-06-21 14:55:41 UTC) #6
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 15:42:24 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5e77d8045bc6904a6925dced1187...

Powered by Google App Engine
This is Rietveld 408576698