Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4491)

Unified Diff: chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc

Issue 2949633002: Do not tie cleanup tool download to SRTPromptFieldTrial field trial (Closed)
Patch Set: Use newer API Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc
diff --git a/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc b/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc
index 4b2faab3d5518b486617a8a5721507d8e5c2614d..356e6f68c89f433e31b4d94d09532ff35b6f08f0 100644
--- a/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc
+++ b/chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win.h"
#include "base/metrics/field_trial.h"
+#include "base/metrics/field_trial_params.h"
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_util.h"
#include "base/win/windows_version.h"
@@ -43,6 +44,9 @@ namespace safe_browsing {
const base::Feature kInBrowserCleanerUIFeature{
"InBrowserCleanerUI", base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kCleanerDownloadFeature{"DownloadCleanupToolByBitness",
+ base::FEATURE_DISABLED_BY_DEFAULT};
+
bool IsInSRTPromptFieldTrialGroups() {
return !base::StartsWith(base::FieldTrialList::FindFullName(kSRTPromptTrial),
kSRTPromptOffGroup, base::CompareCase::SENSITIVE);
@@ -70,8 +74,8 @@ GURL GetLegacyDownloadURL() {
GURL GetSRTDownloadURL() {
constexpr char kDownloadGroupParam[] = "download_group";
- const std::string download_group =
- variations::GetVariationParamValue(kSRTPromptTrial, kDownloadGroupParam);
+ const std::string download_group = base::GetFieldTrialParamValueByFeature(
+ kCleanerDownloadFeature, kDownloadGroupParam);
if (download_group.empty())
return GetLegacyDownloadURL();
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/chrome_cleaner/srt_field_trial_win_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698