Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 294943007: Merge 270252 "Re-land "Move touch CTM from X into Chrome"" (Closed)

Created:
6 years, 7 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, sadrul, tdresser+watch_chromium.org, ben+aura_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Merge 270252 "Re-land "Move touch CTM from X into Chrome"" > Re-land "Move touch CTM from X into Chrome" > > Currently we compute the touch CTM in OutputConfigurator > and push that into X. This CL makes computing the touch CTM > in DisplayController, and pushing it > into WindowTreeHostX11. This moves the functionality of > touch CTM from X into Chrome. > > Basically, when there is output configuration change, we > compute the TouchCTM for each touch device, and push the > TouchCTM into the WindowTreeHostX11 that is associated > with the touchscreen. Then when X events reaching root > window, we use the CTM to map the events coordinate in > framebuffer space into the root window's coordinate space. > > > BUG=351019, chrome-os-partner:25788 > TEST=tested on Pixel/Clapper with external touch/non-touch displays > on both extended/mirror mode. Touch events are correctly mapped to > chrome window or discarded if it is from blank region from letterboxing/pillarboxing mirror mode. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269371 > > TBR=sadrul@chromium.org > > Review URL: https://codereview.chromium.org/280833002 TBR=miletus@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271939

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -518 lines) Patch
M ash/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/ash.gyp View 6 chunks +9 lines, -0 lines 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/display_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/display_info.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ash/display/display_info.cc View 5 chunks +7 lines, -2 lines 0 comments Download
M ash/host/ash_window_tree_host.h View 1 chunk +7 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.h View 3 chunks +9 lines, -10 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 6 chunks +57 lines, -192 lines 0 comments Download
M ash/host/ash_window_tree_host_x11_unittest.cc View 6 chunks +47 lines, -35 lines 0 comments Download
M ash/shell.h View 3 chunks +7 lines, -0 lines 0 comments Download
M ash/shell.cc View 3 chunks +12 lines, -0 lines 0 comments Download
A + ash/touch/touch_transformer_controller.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/touch/touch_transformer_controller.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + ash/touch/touch_transformer_controller_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/aura/window_tree_host_x11.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_x11.cc View 5 chunks +139 lines, -12 lines 0 comments Download
M ui/display/chromeos/display_configurator.h View 7 chunks +4 lines, -35 lines 0 comments Download
M ui/display/chromeos/display_configurator.cc View 6 chunks +2 lines, -97 lines 0 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 4 chunks +0 lines, -61 lines 0 comments Download
M ui/display/chromeos/ozone/touchscreen_delegate_ozone.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/display/chromeos/ozone/touchscreen_delegate_ozone.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/display/chromeos/x11/touchscreen_delegate_x11.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/display/chromeos/x11/touchscreen_delegate_x11.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M ui/events/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/events/event.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/events/event.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/events/events.gyp View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/events/test/events_test_utils_x11.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/x/device_data_manager.h View 4 chunks +19 lines, -0 lines 0 comments Download
M ui/events/x/device_data_manager.cc View 3 chunks +56 lines, -0 lines 0 comments Download
M ui/events/x/events_x.cc View 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yufeng Shen (Slow to review)
6 years, 7 months ago (2014-05-21 19:19:09 UTC) #1
Yufeng Shen (Slow to review)
6 years, 7 months ago (2014-05-21 19:20:14 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r271939.

Powered by Google App Engine
This is Rietveld 408576698