Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 280833002: Re-land "Issue 191223007: Move touch CTM from X into Chrome" (Closed)

Created:
6 years, 7 months ago by Yufeng Shen (Slow to review)
Modified:
6 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, ben+aura_chromium.org, tdresser+watch_chromium.org, sadrul, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Re-land "Move touch CTM from X into Chrome" Currently we compute the touch CTM in OutputConfigurator and push that into X. This CL makes computing the touch CTM in DisplayController, and pushing it into WindowTreeHostX11. This moves the functionality of touch CTM from X into Chrome. Basically, when there is output configuration change, we compute the TouchCTM for each touch device, and push the TouchCTM into the WindowTreeHostX11 that is associated with the touchscreen. Then when X events reaching root window, we use the CTM to map the events coordinate in framebuffer space into the root window's coordinate space. BUG=351019, chrome-os-partner:25788 TEST=tested on Pixel/Clapper with external touch/non-touch displays on both extended/mirror mode. Touch events are correctly mapped to chrome window or discarded if it is from blank region from letterboxing/pillarboxing mirror mode. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269371 TBR=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270252

Patch Set 1 #

Patch Set 2 : adding missing files touch_transformer_controller.* #

Patch Set 3 : adding missing file again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+899 lines, -520 lines) Patch
M ash/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/ash.gyp View 6 chunks +9 lines, -0 lines 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/display/display_info.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ash/display/display_info.cc View 5 chunks +7 lines, -2 lines 0 comments Download
M ash/host/ash_window_tree_host.h View 1 chunk +7 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.h View 3 chunks +9 lines, -10 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 6 chunks +59 lines, -193 lines 0 comments Download
M ash/host/ash_window_tree_host_x11_unittest.cc View 6 chunks +47 lines, -35 lines 0 comments Download
M ash/shell.h View 3 chunks +7 lines, -0 lines 0 comments Download
M ash/shell.cc View 3 chunks +12 lines, -0 lines 0 comments Download
A ash/touch/touch_transformer_controller.h View 1 1 chunk +55 lines, -0 lines 0 comments Download
A ash/touch/touch_transformer_controller.cc View 1 1 chunk +225 lines, -0 lines 0 comments Download
A ash/touch/touch_transformer_controller_unittest.cc View 1 2 1 chunk +206 lines, -0 lines 0 comments Download
M ui/aura/window_tree_host_x11.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_x11.cc View 5 chunks +139 lines, -12 lines 0 comments Download
M ui/display/chromeos/display_configurator.h View 7 chunks +4 lines, -35 lines 0 comments Download
M ui/display/chromeos/display_configurator.cc View 6 chunks +2 lines, -97 lines 0 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 4 chunks +0 lines, -61 lines 0 comments Download
M ui/display/chromeos/ozone/touchscreen_delegate_ozone.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/display/chromeos/ozone/touchscreen_delegate_ozone.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/display/chromeos/x11/touchscreen_delegate_x11.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/display/chromeos/x11/touchscreen_delegate_x11.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M ui/events/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/events/event.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/events/event.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/events/events.gyp View 3 chunks +3 lines, -0 lines 0 comments Download
M ui/events/test/events_test_utils_x11.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ui/events/x/device_data_manager.h View 4 chunks +19 lines, -0 lines 0 comments Download
M ui/events/x/device_data_manager.cc View 3 chunks +56 lines, -0 lines 0 comments Download
M ui/events/x/events_x.cc View 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 7 months ago (2014-05-13 17:01:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/280833002/1
6 years, 7 months ago (2014-05-13 17:01:53 UTC) #2
Yufeng Shen (Slow to review)
sadrul: I am re-landing this now. I moved the TouchCalibrate back to WindowTreeHostX11 for now ...
6 years, 7 months ago (2014-05-13 17:05:39 UTC) #3
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 7 months ago (2014-05-13 18:23:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/280833002/20001
6 years, 7 months ago (2014-05-13 18:23:30 UTC) #5
Yufeng Shen (Slow to review)
The CQ bit was checked by miletus@chromium.org
6 years, 7 months ago (2014-05-13 18:46:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/280833002/30001
6 years, 7 months ago (2014-05-13 18:47:35 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 23:56:51 UTC) #8
Message was sent while issue was closed.
Change committed as 270252

Powered by Google App Engine
This is Rietveld 408576698