Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2949393002: Ensure the search engine promo is still valid before showing in the FRE. (Closed)

Created:
3 years, 6 months ago by Ted C
Modified:
3 years, 6 months ago
Reviewers:
Yusuf
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure the search engine promo is still valid before showing in the FRE. On Android, the properties of what to show in the FRE are calculated the first time it is launched. If you leave in the middle and Chrome is killed, we use the same properties to show it again. For the search engine promo, you can get your phone in a state where it is no longer valid to be shown. In this case, we should ensure the state is still valid before attempting to enqueue the search engine promo screen. BUG=736112 Review-Url: https://codereview.chromium.org/2949393002 Cr-Commit-Position: refs/heads/master@{#481752} Committed: https://chromium.googlesource.com/chromium/src/+/a2da610a03f85063ceb978372fa6d97561eb80c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Ted C
PTAL
3 years, 6 months ago (2017-06-22 23:40:47 UTC) #2
Ted C
PTAL
3 years, 6 months ago (2017-06-22 23:40:48 UTC) #4
Yusuf
lgtm
3 years, 6 months ago (2017-06-22 23:52:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949393002/1
3 years, 6 months ago (2017-06-22 23:53:05 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-23 00:56:17 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2da610a03f85063ceb978372fa6...

Powered by Google App Engine
This is Rietveld 408576698