Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4481)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

Issue 2949393002: Ensure the search engine promo is still valid before showing in the FRE. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
index 465395e5deef56f2cdcc727382d3d137aa8108e9..0473d6e1f25484a18d6df7ed83cfac7227302d60 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
@@ -182,7 +182,8 @@ public class FirstRunActivity extends AsyncInitializationActivity implements Fir
}
// An optional page to select a default search engine.
- if (mFreProperties.getBoolean(SHOW_SEARCH_ENGINE_PAGE)) {
+ if (mFreProperties.getBoolean(SHOW_SEARCH_ENGINE_PAGE)
+ && mFirstRunFlowSequencer.shouldShowSearchEnginePage()) {
mPages.add(pageOf(DefaultSearchEngineFirstRunFragment.class));
mFreProgressStates.add(FRE_PROGRESS_DEFAULT_SEARCH_ENGINE_SHOWN);
notifyAdapter = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698