Try 'sudo chmod' in make_tree_deleteable() as last effort

Try 'sudo chmod' in make_tree_deleteable() as last effort

- Some tasks on Swarming may create root owned files on passwordless sudoer
  account. This CL makes rmtree() try running 'sudo chmod' on linux in case the
  current account happens to be passwordless sudoer. If it fails once, do not
  try again.
- Make rmtree() usable even if fix_encoding() wasn't called so the test case
  above can be used.

Because correctly testing this code requires passwordless sudo, it
has to be manually tested.

The 3 manual test cases to confirm the code works as expected:

1) Verify make_tree_deleteable() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.make_tree_deleteable(os.path.abspath(u"x"))'
    ls -la x x/y
    rm -rf x
  Expected:
    x and x/y are fully deletable without sudo in the last rm -rf.

2) Verify rmtree() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    x and x/y were removed
    A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    sudo -K
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    removal failed

R=vadimsh@chromium.org
BUG=723809
Review-Url: https://codereview.chromium.org/2949253002
Committed: https://github.com/luci/luci-py/commit/274f6429d25c5243eb8043afff854f884b20cf18

[M-A Ruel, 2017-06-22 15:44:13]

Description was changed from

==========
Try sudo chmod in make_tree_deleteable()

Some tasks on Swarming may create root owned files on passwordless sudoer
account.

R=vadimsh@chromium.org
BUG=723809
==========

to

==========
Try sudo chmod in make_tree_deleteable()

Some tasks on Swarming may create root owned files on passwordless sudoer
account.

Manually tested with:
  mkdir -p x/y && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.make_tree_deleteable(os.path.abs(u"x"))'
  sudo ls -la x x/y
  sudo rm -rf x

and:
  mkdir -p x/y && sudo chmod -R a-rwX x
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abs(u"x"))'
  ls -la x

R=vadimsh@chromium.org
BUG=723809
==========

[M-A Ruel, 2017-06-22 15:44:49]

Patchset #1 (id:1) has been deleted

[M-A Ruel, 2017-06-22 15:45:38]

Description was changed from

==========
Try sudo chmod in make_tree_deleteable()

Some tasks on Swarming may create root owned files on passwordless sudoer
account.

Manually tested with:
  mkdir -p x/y && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.make_tree_deleteable(os.path.abs(u"x"))'
  sudo ls -la x x/y
  sudo rm -rf x

and:
  mkdir -p x/y && sudo chmod -R a-rwX x
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abs(u"x"))'
  ls -la x

R=vadimsh@chromium.org
BUG=723809
==========

to

==========
Try sudo chmod in make_tree_deleteable()

Some tasks on Swarming may create root owned files on passwordless sudoer
account.

Manually tested with:
  mkdir -p x/y && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.make_tree_deleteable(os.path.abspath(u"x"))'
  sudo ls -la x x/y
  sudo rm -rf x

and:
  mkdir -p x/y && sudo chmod -R a-rwX x
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x

R=vadimsh@chromium.org
BUG=723809
==========

[M-A Ruel, 2017-06-22 15:49:12]

Patchset #1 (id:20001) has been deleted

[M-A Ruel, 2017-06-22 15:49:17]

Patchset #1 (id:40001) has been deleted

[M-A Ruel, 2017-06-22 15:51:44]

Description was changed from

==========
Try sudo chmod in make_tree_deleteable()

Some tasks on Swarming may create root owned files on passwordless sudoer
account.

Manually tested with:
  mkdir -p x/y && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.make_tree_deleteable(os.path.abspath(u"x"))'
  sudo ls -la x x/y
  sudo rm -rf x

and:
  mkdir -p x/y && sudo chmod -R a-rwX x
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x

R=vadimsh@chromium.org
BUG=723809
==========

to

==========
Try sudo chmod in make_tree_deleteable()

Some tasks on Swarming may create root owned files on passwordless sudoer
account.

Manually tested:

1) Verify make_tree_deleteable() works with passwordless sudo:
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.make_tree_deleteable(os.path.abspath(u"x"))'
  sudo ls -la x x/y
  sudo rm -rf x

2) Verify rmtree() works with passwordless sudo:
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x

3) Verify that a sudo password prompt fails the rmtree():
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  sudo -K
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x

R=vadimsh@chromium.org
BUG=723809
==========

[M-A Ruel, 2017-06-22 15:54:15]

Description was changed from

==========
Try sudo chmod in make_tree_deleteable()

Some tasks on Swarming may create root owned files on passwordless sudoer
account.

Manually tested:

1) Verify make_tree_deleteable() works with passwordless sudo:
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.make_tree_deleteable(os.path.abspath(u"x"))'
  sudo ls -la x x/y
  sudo rm -rf x

2) Verify rmtree() works with passwordless sudo:
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x

3) Verify that a sudo password prompt fails the rmtree():
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  sudo -K
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x

R=vadimsh@chromium.org
BUG=723809
==========

to

==========
Try sudo chmod in make_tree_deleteable()

Some tasks on Swarming may create root owned files on passwordless sudoer
account.

Manually tested:

1) Verify make_tree_deleteable() works with passwordless sudo:
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.make_tree_deleteable(os.path.abspath(u"x"))'
  ls -la x x/y
  sudo rm -rf x
Expected:
  x and x/y are fully writeable.

2) Verify rmtree() works with passwordless sudo:
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x
Expected:
  x and x/y were removed
  A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  sudo -K
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x
Expected:
  removal failed

R=vadimsh@chromium.org
BUG=723809
==========

[M-A Ruel, 2017-06-22 15:55:54]

Description was changed from

==========
Try sudo chmod in make_tree_deleteable()

Some tasks on Swarming may create root owned files on passwordless sudoer
account.

Manually tested:

1) Verify make_tree_deleteable() works with passwordless sudo:
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.make_tree_deleteable(os.path.abspath(u"x"))'
  ls -la x x/y
  sudo rm -rf x
Expected:
  x and x/y are fully writeable.

2) Verify rmtree() works with passwordless sudo:
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x
Expected:
  x and x/y were removed
  A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  sudo -K
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x
Expected:
  removal failed

R=vadimsh@chromium.org
BUG=723809
==========

to

==========
Try 'sudo chmod' in make_tree_deleteable() as last effort

Some tasks on Swarming may create root owned files on passwordless sudoer
account. Try running 'sudo chmod' on linux.

Because correctly testing this code requires passwordless sudo, it
has to be manually tested.

The 3 manual test cases to confirm the code works as expected:

1) Verify make_tree_deleteable() works with passwordless sudo:
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.make_tree_deleteable(os.path.abspath(u"x"))'
  ls -la x x/y
  sudo rm -rf x
Expected:
  x and x/y are fully writeable.

2) Verify rmtree() works with passwordless sudo:
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x
Expected:
  x and x/y were removed
  A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  sudo -K
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x
Expected:
  removal failed

R=vadimsh@chromium.org
BUG=723809
==========

[M-A Ruel, 2017-06-22 15:57:51]

Description was changed from

==========
Try 'sudo chmod' in make_tree_deleteable() as last effort

Some tasks on Swarming may create root owned files on passwordless sudoer
account. Try running 'sudo chmod' on linux.

Because correctly testing this code requires passwordless sudo, it
has to be manually tested.

The 3 manual test cases to confirm the code works as expected:

1) Verify make_tree_deleteable() works with passwordless sudo:
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.make_tree_deleteable(os.path.abspath(u"x"))'
  ls -la x x/y
  sudo rm -rf x
Expected:
  x and x/y are fully writeable.

2) Verify rmtree() works with passwordless sudo:
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x
Expected:
  x and x/y were removed
  A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
  mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
  sudo ls -la x x/y
  sudo -K
  python -c 'import os; from utils import file_path; \
    file_path.rmtree(os.path.abspath(u"x"))'
  ls -la x
Expected:
  removal failed

R=vadimsh@chromium.org
BUG=723809
==========

to

==========
Try 'sudo chmod' in make_tree_deleteable() as last effort

Some tasks on Swarming may create root owned files on passwordless sudoer
account. Try running 'sudo chmod' on linux.

Because correctly testing this code requires passwordless sudo, it
has to be manually tested.

The 3 manual test cases to confirm the code works as expected:

1) Verify make_tree_deleteable() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.make_tree_deleteable(os.path.abspath(u"x"))'
    ls -la x x/y
    sudo rm -rf x
  Expected:
    x and x/y are fully writeable.

2) Verify rmtree() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    x and x/y were removed
    A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    sudo -K
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    removal failed


Make rmtree() usable even if fix_encoding() wasn't called so the test case above
can be used.

R=vadimsh@chromium.org
BUG=723809
==========

[M-A Ruel, 2017-06-22 15:58:26]

Description was changed from

==========
Try 'sudo chmod' in make_tree_deleteable() as last effort

Some tasks on Swarming may create root owned files on passwordless sudoer
account. Try running 'sudo chmod' on linux.

Because correctly testing this code requires passwordless sudo, it
has to be manually tested.

The 3 manual test cases to confirm the code works as expected:

1) Verify make_tree_deleteable() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.make_tree_deleteable(os.path.abspath(u"x"))'
    ls -la x x/y
    sudo rm -rf x
  Expected:
    x and x/y are fully writeable.

2) Verify rmtree() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    x and x/y were removed
    A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    sudo -K
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    removal failed


Make rmtree() usable even if fix_encoding() wasn't called so the test case above
can be used.

R=vadimsh@chromium.org
BUG=723809
==========

to

==========
Try 'sudo chmod' in make_tree_deleteable() as last effort

- Some tasks on Swarming may create root owned files on passwordless sudoer
  account. Try running 'sudo chmod' on linux. If it fails once, do not try
  again.
- Make rmtree() usable even if fix_encoding() wasn't called so the test case
  above can be used.

Because correctly testing this code requires passwordless sudo, it
has to be manually tested.

The 3 manual test cases to confirm the code works as expected:

1) Verify make_tree_deleteable() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.make_tree_deleteable(os.path.abspath(u"x"))'
    ls -la x x/y
    sudo rm -rf x
  Expected:
    x and x/y are fully writeable.

2) Verify rmtree() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    x and x/y were removed
    A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    sudo -K
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    removal failed

R=vadimsh@chromium.org
BUG=723809
==========

[M-A Ruel, 2017-06-22 15:59:14]

Description was changed from

==========
Try 'sudo chmod' in make_tree_deleteable() as last effort

- Some tasks on Swarming may create root owned files on passwordless sudoer
  account. Try running 'sudo chmod' on linux. If it fails once, do not try
  again.
- Make rmtree() usable even if fix_encoding() wasn't called so the test case
  above can be used.

Because correctly testing this code requires passwordless sudo, it
has to be manually tested.

The 3 manual test cases to confirm the code works as expected:

1) Verify make_tree_deleteable() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.make_tree_deleteable(os.path.abspath(u"x"))'
    ls -la x x/y
    sudo rm -rf x
  Expected:
    x and x/y are fully writeable.

2) Verify rmtree() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    x and x/y were removed
    A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    sudo -K
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    removal failed

R=vadimsh@chromium.org
BUG=723809
==========

to

==========
Try 'sudo chmod' in make_tree_deleteable() as last effort

- Some tasks on Swarming may create root owned files on passwordless sudoer
  account. This CL makes rmtree() try running 'sudo chmod' on linux in case the
  current account happens to be passwordless sudoer. If it fails once, do not
  try again.
- Make rmtree() usable even if fix_encoding() wasn't called so the test case
  above can be used.

Because correctly testing this code requires passwordless sudo, it
has to be manually tested.

The 3 manual test cases to confirm the code works as expected:

1) Verify make_tree_deleteable() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.make_tree_deleteable(os.path.abspath(u"x"))'
    ls -la x x/y
    sudo rm -rf x
  Expected:
    x and x/y are fully writeable.

2) Verify rmtree() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    x and x/y were removed
    A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    sudo -K
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    removal failed

R=vadimsh@chromium.org
BUG=723809
==========

[Vadim Sh., 2017-06-22 17:03:06]

lgtm

[M-A Ruel, 2017-06-22 17:17:00]

Description was changed from

==========
Try 'sudo chmod' in make_tree_deleteable() as last effort

- Some tasks on Swarming may create root owned files on passwordless sudoer
  account. This CL makes rmtree() try running 'sudo chmod' on linux in case the
  current account happens to be passwordless sudoer. If it fails once, do not
  try again.
- Make rmtree() usable even if fix_encoding() wasn't called so the test case
  above can be used.

Because correctly testing this code requires passwordless sudo, it
has to be manually tested.

The 3 manual test cases to confirm the code works as expected:

1) Verify make_tree_deleteable() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.make_tree_deleteable(os.path.abspath(u"x"))'
    ls -la x x/y
    sudo rm -rf x
  Expected:
    x and x/y are fully writeable.

2) Verify rmtree() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    x and x/y were removed
    A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    sudo -K
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    removal failed

R=vadimsh@chromium.org
BUG=723809
==========

to

==========
Try 'sudo chmod' in make_tree_deleteable() as last effort

- Some tasks on Swarming may create root owned files on passwordless sudoer
  account. This CL makes rmtree() try running 'sudo chmod' on linux in case the
  current account happens to be passwordless sudoer. If it fails once, do not
  try again.
- Make rmtree() usable even if fix_encoding() wasn't called so the test case
  above can be used.

Because correctly testing this code requires passwordless sudo, it
has to be manually tested.

The 3 manual test cases to confirm the code works as expected:

1) Verify make_tree_deleteable() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.make_tree_deleteable(os.path.abspath(u"x"))'
    ls -la x x/y
    rm -rf x
  Expected:
    x and x/y are fully deletable without sudo in the last rm -rf.

2) Verify rmtree() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    x and x/y were removed
    A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    sudo -K
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    removal failed

R=vadimsh@chromium.org
BUG=723809
==========

[M-A Ruel, 2017-06-22 17:19:34]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2017-06-22 17:19:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 17:22:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498151974098760,
"parent_rev": "8122a5d84198cd85ade442dbdcb4d3ef5ca2dc2c", "commit_rev":
"274f6429d25c5243eb8043afff854f884b20cf18"}

[commit-bot: I haz the power, 2017-06-22 17:22:31]

Description was changed from

==========
Try 'sudo chmod' in make_tree_deleteable() as last effort

- Some tasks on Swarming may create root owned files on passwordless sudoer
  account. This CL makes rmtree() try running 'sudo chmod' on linux in case the
  current account happens to be passwordless sudoer. If it fails once, do not
  try again.
- Make rmtree() usable even if fix_encoding() wasn't called so the test case
  above can be used.

Because correctly testing this code requires passwordless sudo, it
has to be manually tested.

The 3 manual test cases to confirm the code works as expected:

1) Verify make_tree_deleteable() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.make_tree_deleteable(os.path.abspath(u"x"))'
    ls -la x x/y
    rm -rf x
  Expected:
    x and x/y are fully deletable without sudo in the last rm -rf.

2) Verify rmtree() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    x and x/y were removed
    A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    sudo -K
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    removal failed

R=vadimsh@chromium.org
BUG=723809
==========

to

==========
Try 'sudo chmod' in make_tree_deleteable() as last effort

- Some tasks on Swarming may create root owned files on passwordless sudoer
  account. This CL makes rmtree() try running 'sudo chmod' on linux in case the
  current account happens to be passwordless sudoer. If it fails once, do not
  try again.
- Make rmtree() usable even if fix_encoding() wasn't called so the test case
  above can be used.

Because correctly testing this code requires passwordless sudo, it
has to be manually tested.

The 3 manual test cases to confirm the code works as expected:

1) Verify make_tree_deleteable() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.make_tree_deleteable(os.path.abspath(u"x"))'
    ls -la x x/y
    rm -rf x
  Expected:
    x and x/y are fully deletable without sudo in the last rm -rf.

2) Verify rmtree() works with passwordless sudo:
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    x and x/y were removed
    A logging warning was printed

3) Verify that a sudo password prompt fails the rmtree():
    mkdir -p x/y && sudo chown -R root:root x && sudo chmod -R a-rwX x
    sudo ls -la x x/y
    sudo -K
    python -c 'import os; from utils import file_path; \
      file_path.rmtree(os.path.abspath(u"x"))'
    ls -la x
  Expected:
    removal failed

R=vadimsh@chromium.org
BUG=723809

Review-Url: https://codereview.chromium.org/2949253002
Committed:
https://github.com/luci/luci-py/commit/274f6429d25c5243eb8043afff854f884b20cf18
==========

[commit-bot: I haz the power, 2017-06-22 17:22:33]

Committed patchset #1 (id:60001) as
https://github.com/luci/luci-py/commit/274f6429d25c5243eb8043afff854f884b20cf18