Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2949103004: Shuffle code around in file_path. (Closed)

Created:
3 years, 6 months ago by M-A Ruel
Modified:
3 years, 6 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

Shuffle code around in file_path. Eventually run_isolated needs to call kill_children_processes() when unlinking named caches. This CL moves code around and changes what is public/private as a preparation for this work but doesn't have functional changes. Delete cleanup_path(), as it was unused. R=vadimsh@chromium.org BUG=735221 Review-Url: https://codereview.chromium.org/2949103004 Committed: https://github.com/luci/luci-py/commit/8122a5d84198cd85ade442dbdcb4d3ef5ca2dc2c

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -152 lines) Patch
M client/utils/file_path.py View 11 chunks +154 lines, -152 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
M-A Ruel
Sorry for this annoying code move CL but I'm thinking of generalizing kill_children_processes() so it ...
3 years, 6 months ago (2017-06-22 14:56:37 UTC) #2
Vadim Sh.
rs lgtm
3 years, 6 months ago (2017-06-22 17:08:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949103004/20001
3 years, 6 months ago (2017-06-22 17:15:37 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 17:18:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://github.com/luci/luci-py/commit/8122a5d84198cd85ade442dbdcb4d3ef5ca2dc2c

Powered by Google App Engine
This is Rietveld 408576698