[Extensions Bindings] Support ArrayBufferView in idl files

[Extensions Bindings] Support ArrayBufferView in idl files

Currently, to specify an ArrayBufferView in an IDL file, we use
`[instanceOf=Uint8Array] object view`

Change this to
`[instanceOf=Uint8Array] ArrayBufferView view`

Update the schema compiler to consider the type of ArrayBufferView to
be `binary`, rather than `object`, so that these values are properly
converted in native bindings.

BUG=653596
TEST=browser_tests --gtest_filter=ExtensionIdltestApiTest.IdlCompiler

Review-Url: https://codereview.chromium.org/2949143002
Cr-Commit-Position: refs/heads/master@{#482120}
Committed: https://chromium.googlesource.com/chromium/src/+/b35688d3937842851444f07370dfe09cb94dd1b9

[Devlin, 2017-06-22 00:42:29]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 00:42:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 01:49:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 01:49:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Devlin, 2017-06-22 16:12:18]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 16:12:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 17:29:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 17:29:24]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-06-22 21:53:22]

Description was changed from

==========
idl fix
BUG=
==========

to

==========
[Extensions Bindings] Support ArrayBufferView in idl files

Currently, to specify an ArrayBufferView in an IDL file, we use
`[instanceOf=Uint8Array] object view`

Change this to
`[instanceOf=Uint8Array] ArrayBufferView view`

Update the schema compiler to consider the type of ArrayBufferView to
be `binary`, rather than `object`, so that these values are properly
converted in native bindings.

BUG=653596
TEST=browser_tests --gtest_filter=ExtensionIdltestApiTest.IdlCompiler
==========

[Devlin, 2017-06-22 21:54:57]

rdevlin.cronin@chromium.org changed reviewers:
+ jbroman@chromium.org, lazyboy@chromium.org

[Devlin, 2017-06-22 21:54:58]

I'm not thrilled with this, and I don't think we actually *use* ArrayBufferView
arguments anywhere, so I'm tempted to just remove support altogether.  But it
seemed like that should be a separate conversation...

https://codereview.chromium.org/2949143002/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/idltest.idl (right):

https://codereview.chromium.org/2949143002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/idltest.idl:21: [instanceOf=Uint8Array]
ArrayBufferView input,
We could actually just remove this [instanceOf] and only add it when necessary,
but that's orthogonal to this change.

[jbroman, 2017-06-23 18:22:42]

lgtm

[lazyboy, 2017-06-24 00:53:16]

lgtm

https://codereview.chromium.org/2949143002/diff/20001/tools/json_schema_compi...
File tools/json_schema_compiler/idl_schema.py (right):

https://codereview.chromium.org/2949143002/diff/20001/tools/json_schema_compi...
tools/json_schema_compiler/idl_schema.py:320: # We force the APIs to specify
instanceOf since ArrayBufferView isn't an
nit: also add: therefore we don't specify instanceOf here.

[Devlin, 2017-06-24 00:57:47]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-24 00:57:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2017-06-24 02:05:26]

https://codereview.chromium.org/2949143002/diff/20001/tools/json_schema_compi...
File tools/json_schema_compiler/idl_schema.py (right):

https://codereview.chromium.org/2949143002/diff/20001/tools/json_schema_compi...
tools/json_schema_compiler/idl_schema.py:320: # We force the APIs to specify
instanceOf since ArrayBufferView isn't an
On 2017/06/24 00:53:16, lazyboy wrote:
> nit: also add: therefore we don't specify instanceOf here.

Done.

[Devlin, 2017-06-24 02:05:32]

The CQ bit was unchecked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-24 02:05:37]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-06-24 02:05:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
lazyboy@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2949143002/#ps40001
(title: "extend comment")

[commit-bot: I haz the power, 2017-06-24 02:05:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-24 02:14:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498269937301710,
"parent_rev": "fedbe848f3024dd690f93545a337a2a6fb2aa81f", "commit_rev":
"b35688d3937842851444f07370dfe09cb94dd1b9"}

[commit-bot: I haz the power, 2017-06-24 02:14:29]

Description was changed from

==========
[Extensions Bindings] Support ArrayBufferView in idl files

Currently, to specify an ArrayBufferView in an IDL file, we use
`[instanceOf=Uint8Array] object view`

Change this to
`[instanceOf=Uint8Array] ArrayBufferView view`

Update the schema compiler to consider the type of ArrayBufferView to
be `binary`, rather than `object`, so that these values are properly
converted in native bindings.

BUG=653596
TEST=browser_tests --gtest_filter=ExtensionIdltestApiTest.IdlCompiler
==========

to

==========
[Extensions Bindings] Support ArrayBufferView in idl files

Currently, to specify an ArrayBufferView in an IDL file, we use
`[instanceOf=Uint8Array] object view`

Change this to
`[instanceOf=Uint8Array] ArrayBufferView view`

Update the schema compiler to consider the type of ArrayBufferView to
be `binary`, rather than `object`, so that these values are properly
converted in native bindings.

BUG=653596
TEST=browser_tests --gtest_filter=ExtensionIdltestApiTest.IdlCompiler

Review-Url: https://codereview.chromium.org/2949143002
Cr-Commit-Position: refs/heads/master@{#482120}
Committed:
https://chromium.googlesource.com/chromium/src/+/b35688d3937842851444f07370df...
==========

[commit-bot: I haz the power, 2017-06-24 02:14:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b35688d3937842851444f07370df...