extensions/renderer/v8_schema_registry.cc - Issue 2949143002: [Extensions Bindings] Support ArrayBufferView in idl files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/v8_schema_registry.cc

Issue 2949143002: [Extensions Bindings] Support ArrayBufferView in idl files (Closed)

Patch Set: extend comment Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/v8_schema_registry.cc

diff --git a/extensions/renderer/v8_schema_registry.cc b/extensions/renderer/v8_schema_registry.cc

index 87117f68a477bb936235b54e31f74f55a92fa052..bdb9536d7e5cee31203e65db9718c2de65a97e83 100644

--- a/extensions/renderer/v8_schema_registry.cc

+++ b/extensions/renderer/v8_schema_registry.cc

@@ -67,7 +67,7 @@ class SchemaRegistryNativeHandler : public ObjectBackedNativeHandler {

std::string type;

if (args[0]->IsArray())

type = "array";

- else if (args[0]->IsArrayBuffer())

+ else if (args[0]->IsArrayBuffer() || args[0]->IsArrayBufferView())

type = "binary";

else

type = "object";