Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2949103003: Remove more dead code from analysis server (Closed)

Created:
3 years, 6 months ago by Brian Wilkerson
Modified:
3 years, 5 months ago
Reviewers:
devoncarew, scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -424 lines) Patch
M pkg/analysis_server/lib/plugin/analysis/analysis_domain.dart View 2 chunks +1 line, -16 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 13 chunks +11 lines, -118 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 16 chunks +36 lines, -171 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 3 chunks +25 lines, -30 lines 2 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +7 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 13 chunks +16 lines, -85 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
3 years, 6 months ago (2017-06-22 14:36:13 UTC) #2
devoncarew
lgtm
3 years, 6 months ago (2017-06-22 14:51:12 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as a420a1fbb543605ea7e2e8d6c8c62060558bdcb8 (presubmit successful).
3 years, 6 months ago (2017-06-22 15:21:10 UTC) #5
scheglov
LGTM https://codereview.chromium.org/2949103003/diff/1/pkg/analysis_server/lib/src/domain_analysis.dart File pkg/analysis_server/lib/src/domain_analysis.dart (right): https://codereview.chromium.org/2949103003/diff/1/pkg/analysis_server/lib/src/domain_analysis.dart#newcode457 pkg/analysis_server/lib/src/domain_analysis.dart:457: void _subscribeForContext(engine.AnalysisContext context) { IIRC, this was implemented ...
3 years, 5 months ago (2017-06-26 15:49:45 UTC) #6
Brian Wilkerson
3 years, 5 months ago (2017-06-26 16:27:54 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2949103003/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/domain_analysis.dart (right):

https://codereview.chromium.org/2949103003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/domain_analysis.dart:457: void
_subscribeForContext(engine.AnalysisContext context) {
Yep. It was deleted in a later CL.

Powered by Google App Engine
This is Rietveld 408576698