Remove more dead code from analysis server

pkg/analysis_server/lib/src/domain_analysis.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:core';
 
 import 'package:analysis_server/plugin/analysis/analysis_domain.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/computer/computer_hover.dart';
 import 'package:analysis_server/src/constants.dart';
 import 'package:analysis_server/src/context_manager.dart';
 import 'package:analysis_server/src/domain_abstract.dart';
 import 'package:analysis_server/src/domains/analysis/navigation.dart';
 import 'package:analysis_server/src/domains/analysis/navigation_dart.dart';
 import 'package:analysis_server/src/operation/operation_analysis.dart'
     show NavigationOperation, OccurrencesOperation;
 import 'package:analysis_server/src/plugin/plugin_manager.dart';
 import 'package:analysis_server/src/plugin/request_converter.dart';
 import 'package:analysis_server/src/plugin/result_merger.dart';
 import 'package:analysis_server/src/protocol/protocol_internal.dart';
 import 'package:analysis_server/src/protocol_server.dart';
-import 'package:analysis_server/src/services/dependencies/library_dependencies.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/error/error.dart' as engine;
 import 'package:analyzer/exception/exception.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/dart/analysis/driver.dart';
 import 'package:analyzer/src/generated/engine.dart' as engine;
 import 'package:analyzer/src/generated/source.dart';
 import 'package:analyzer/task/model.dart' show ResultDescriptor;
 import 'package:analyzer_plugin/protocol/protocol.dart' as plugin;
 import 'package:analyzer_plugin/protocol/protocol_common.dart';
@@ skipping 62 matching lines @@
       if (hoverInformation != null) {
         hovers.add(hoverInformation);
       }
     }
 
     // Send the response.
     server.sendResponse(
         new AnalysisGetHoverResult(hovers).toResponse(request.id));
   }
 
-  /// Implement the `analysis.getLibraryDependencies` request.
+  /**
+   * Implement the `analysis.getLibraryDependencies` request.
+   */
   Response getLibraryDependencies(Request request) {
-    server.onAnalysisComplete.then((_) {
-      LibraryDependencyCollector collector =
-          new LibraryDependencyCollector(server.analysisContexts);
-      Set<String> libraries = collector.collectLibraryDependencies();
-      Map<String, Map<String, List<String>>> packageMap =
-          collector.calculatePackageMap(server.folderMap);
-      server.sendResponse(new AnalysisGetLibraryDependenciesResult(
-              libraries.toList(growable: false), packageMap)
-          .toResponse(request.id));
-    }).catchError((error, st) {
-      server.sendResponse(new Response.serverError(request, error, st));
-    });
-    // delay response
-    return Response.DELAYED_RESPONSE;
+    return new Response.unsupportedFeature(request.id,
+        'Please contact the Dart analyzer team if you need this request.');
+//    server.onAnalysisComplete.then((_) {
+//      LibraryDependencyCollector collector =
+//          new LibraryDependencyCollector(server.analysisContexts);
+//      Set<String> libraries = collector.collectLibraryDependencies();
+//      Map<String, Map<String, List<String>>> packageMap =
+//          collector.calculatePackageMap(server.folderMap);
+//      server.sendResponse(new AnalysisGetLibraryDependenciesResult(
+//              libraries.toList(growable: false), packageMap)
+//          .toResponse(request.id));
+//    }).catchError((error, st) {
+//      server.sendResponse(new Response.serverError(request, error, st));
+//    });
+//    // delay response
+//    return Response.DELAYED_RESPONSE;
   }
 
   /**
    * Implement the `analysis.getNavigation` request.
    */
   Future<Null> getNavigation(Request request) async {
     var params = new AnalysisGetNavigationParams.fromRequest(request);
     String file = params.file;
     int offset = params.offset;
     int length = params.length;
@@ skipping 290 matching lines @@
  * An implementation of [AnalysisDomain] for [AnalysisServer].
  */
 class AnalysisDomainImpl implements AnalysisDomain {
   final AnalysisServer server;
 
   final Map<ResultDescriptor, StreamController<engine.ResultChangedEvent>>
       controllers =
       <ResultDescriptor, StreamController<engine.ResultChangedEvent>>{};
 
   AnalysisDomainImpl(this.server) {
-    server.onContextsChanged.listen((ContextsChangedEvent event) {
-      event.added.forEach(_subscribeForContext);
-    });
+    // TODO(brianwilkerson) The onContextsChanged stream is no longer written to.
+    // Figure out whether this code still needs to be here and convert it to use
+    // the analysis driver if it does.
+//    server.onContextsChanged.listen((ContextsChangedEvent event) {
+//      event.added.forEach(_subscribeForContext);
+//    });
   }
 
   @override
-  Stream<engine.ResultChangedEvent> onResultChanged(
-      ResultDescriptor descriptor) {
-    Stream<engine.ResultChangedEvent> stream =
-        controllers.putIfAbsent(descriptor, () {
-      return new StreamController<engine.ResultChangedEvent>.broadcast();
-    }).stream;
-    server.analysisContexts.forEach(_subscribeForContext);
-    return stream;
-  }
-
-  @override
   void scheduleNotification(
       engine.AnalysisContext context, Source source, AnalysisService service) {
     String file = source.fullName;
     if (server.hasAnalysisSubscription(service, file)) {
       if (service == AnalysisService.NAVIGATION) {
         server.scheduleOperation(new NavigationOperation(context, source));
       }
       if (service == AnalysisService.OCCURRENCES) {
         server.scheduleOperation(new OccurrencesOperation(context, source));
       }
     }
   }
 
   void _subscribeForContext(engine.AnalysisContext context) {

[scheglov, 2017/06/26 15:49:45]

IIRC, this was implemented for in-process Angular analysis plugin.
We don't need it anymore.

[Brian Wilkerson, 2017/06/26 16:27:54]

Yep. It was deleted in a later CL.

     for (ResultDescriptor descriptor in controllers.keys) {
       context.onResultChanged(descriptor).listen((result) {
         StreamController<engine.ResultChangedEvent> controller =
             controllers[result.descriptor];
         if (controller != null) {
           controller.add(result);
         }
       });
     }
   }
 }