Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: pkg/analysis_server/lib/src/operation/operation_analysis.dart

Issue 2949103003: Remove more dead code from analysis server (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/operation/operation_analysis.dart
diff --git a/pkg/analysis_server/lib/src/operation/operation_analysis.dart b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
index 2584dbdec6e80309bd69a16d91bad08edef5c58b..a6d2045f46cdead0dee6d23cf2521488f064ffca 100644
--- a/pkg/analysis_server/lib/src/operation/operation_analysis.dart
+++ b/pkg/analysis_server/lib/src/operation/operation_analysis.dart
@@ -91,11 +91,14 @@ void scheduleNotificationOperations(
CompilationUnit parsedDartUnit,
CompilationUnit resolvedDartUnit,
List<AnalysisError> errors) {
+ // TODO(brianwilkerson) The `containingContext` will always be `null`. If this
+ // check is still useful, we should re-write it to use drivers.
+ //
// If the file belongs to any analysis root, check whether we're in it now.
- AnalysisContext containingContext = server.getContainingContext(file);
- if (containingContext != null && context != containingContext) {
- return;
- }
+// AnalysisContext containingContext = server.getContainingContext(file);
+// if (containingContext != null && context != containingContext) {
+// return;
+// }
// Dart
CompilationUnit dartUnit = resolvedDartUnit ?? parsedDartUnit;
if (resolvedDartUnit != null) {

Powered by Google App Engine
This is Rietveld 408576698