Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2949043002: Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (Closed)

Created:
3 years, 6 months ago by martiniss
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke, erikchen
CC:
chromium-reviews, mac-reviews_chromium.org, justincohen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mac: Roll hermetic toolchain to Xcode 8.3.2. (patchset #2 id:20001 of https://codereview.chromium.org/2950933003/ ) Reason for revert: Broke mac builders on chromium.perf: https://build.chromium.org/p/chromium.perf/builders/Mac%20Builder/builds/102244 Original issue's description: > mac: Roll hermetic toolchain to Xcode 8.3.2. > > Xcode 8.3.2 requires macOS 10.12+. This version of Xcode 8.3.2 has both the > 10.10 and 10.12 SDKs, and builds will continue to use the 10.10 SDK. > > To support machines running macOS versions < 10.12, but don't require building > targets, this CL also: > * Does not download the hermetic toolchain if the macOS version does not > support the toolchain version. > * Does not allow building targets with the default hermetic toolchain if the > macOS version does not support the toolchain version. > > BUG=624049 > > Review-Url: https://codereview.chromium.org/2950933003 > Cr-Commit-Position: refs/heads/master@{#481225} > Committed: https://chromium.googlesource.com/chromium/src/+/2f19b143e444c920e643feda583e9ceb72d29c8e TBR=dpranke@chromium.org,erikchen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624049 Review-Url: https://codereview.chromium.org/2949043002 Cr-Commit-Position: refs/heads/master@{#481241} Committed: https://chromium.googlesource.com/chromium/src/+/81095e19266ad3da6479a5889793842fe49a437b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -33 lines) Patch
M build/mac/should_use_hermetic_xcode.py View 3 chunks +2 lines, -13 lines 0 comments Download
M build/mac_toolchain.py View 4 chunks +1 line, -17 lines 0 comments Download
M build_overrides/build.gni View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
martiniss
Created Revert of mac: Roll hermetic toolchain to Xcode 8.3.2.
3 years, 6 months ago (2017-06-21 18:10:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2949043002/1
3 years, 6 months ago (2017-06-21 18:11:04 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/81095e19266ad3da6479a5889793842fe49a437b
3 years, 6 months ago (2017-06-21 18:12:25 UTC) #6
erikchen
lgtm
3 years, 6 months ago (2017-06-21 18:12:29 UTC) #7
Dirk Pranke
3 years, 6 months ago (2017-06-21 19:08:35 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698