Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: components/history/core/browser/history_types.h

Issue 2949023002: [WIP] Fix history.replaceState() not propagating back favicons (Closed)
Patch Set: Focus on history.replaceState() Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/history/core/browser/history_types.h
diff --git a/components/history/core/browser/history_types.h b/components/history/core/browser/history_types.h
index 17b97b4a038eccc31009b293b75e9c50db378b6e..b0c024c92a0807034465ce336c4b6f0f5fc3428c 100644
--- a/components/history/core/browser/history_types.h
+++ b/components/history/core/browser/history_types.h
@@ -18,6 +18,7 @@
#include "base/containers/stack_container.h"
#include "base/macros.h"
#include "base/memory/ref_counted_memory.h"
+#include "base/optional.h"
#include "base/strings/string16.h"
#include "base/time/time.h"
#include "components/favicon_base/favicon_types.h"
@@ -365,7 +366,7 @@ struct HistoryAddPageArgs {
const RedirectList& redirects,
ui::PageTransition transition,
VisitSource source,
- bool did_replace_entry,
+ base::Optional<GURL> replaced_entry_url,
bool consider_for_ntp_most_visited);
HistoryAddPageArgs(const HistoryAddPageArgs& other);
~HistoryAddPageArgs();
@@ -378,7 +379,7 @@ struct HistoryAddPageArgs {
RedirectList redirects;
ui::PageTransition transition;
VisitSource visit_source;
- bool did_replace_entry;
+ base::Optional<GURL> replaced_entry_url;
// Specifies whether a page visit should contribute to the Most Visited tiles
// in the New Tab Page. Note that setting this to true (most common case)
// doesn't guarantee it's relevant for Most Visited, since other requirements
« no previous file with comments | « components/history/core/browser/history_service.cc ('k') | components/history/core/browser/history_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698