Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Unified Diff: components/history/core/browser/history_service.cc

Issue 2949023002: [WIP] Fix history.replaceState() not propagating back favicons (Closed)
Patch Set: Focus on history.replaceState() Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/history/core/browser/history_service.h ('k') | components/history/core/browser/history_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history/core/browser/history_service.cc
diff --git a/components/history/core/browser/history_service.cc b/components/history/core/browser/history_service.cc
index 6e8b789018bdc4f31e33c27da30a5d072bf9b917..9baf821cc3976b8815b626b8399a6b6b3f6ee8fe 100644
--- a/components/history/core/browser/history_service.cc
+++ b/components/history/core/browser/history_service.cc
@@ -377,11 +377,11 @@ void HistoryService::AddPage(const GURL& url,
const RedirectList& redirects,
ui::PageTransition transition,
VisitSource visit_source,
- bool did_replace_entry) {
+ base::Optional<GURL> replaced_entry_url) {
DCHECK(thread_checker_.CalledOnValidThread());
AddPage(HistoryAddPageArgs(url, time, context_id, nav_entry_id, referrer,
redirects, transition, visit_source,
- did_replace_entry, true));
+ replaced_entry_url, true));
}
void HistoryService::AddPage(const GURL& url,
@@ -389,8 +389,8 @@ void HistoryService::AddPage(const GURL& url,
VisitSource visit_source) {
DCHECK(thread_checker_.CalledOnValidThread());
AddPage(HistoryAddPageArgs(url, time, nullptr, 0, GURL(), RedirectList(),
- ui::PAGE_TRANSITION_LINK, visit_source, false,
- true));
+ ui::PAGE_TRANSITION_LINK, visit_source,
+ base::nullopt, true));
}
void HistoryService::AddPage(const HistoryAddPageArgs& add_page_args) {
« no previous file with comments | « components/history/core/browser/history_service.h ('k') | components/history/core/browser/history_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698