Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: components/history/core/browser/history_types.cc

Issue 2949023002: [WIP] Fix history.replaceState() not propagating back favicons (Closed)
Patch Set: Focus on history.replaceState() Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/history/core/browser/history_types.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/history/core/browser/history_types.cc
diff --git a/components/history/core/browser/history_types.cc b/components/history/core/browser/history_types.cc
index 1624e636b2ad60b4d51938a33995f34272b90470..26a4871b90d22ec74e31acd9d9cbe4aee37000d6 100644
--- a/components/history/core/browser/history_types.cc
+++ b/components/history/core/browser/history_types.cc
@@ -240,9 +240,8 @@ HistoryAddPageArgs::HistoryAddPageArgs()
RedirectList(),
ui::PAGE_TRANSITION_LINK,
SOURCE_BROWSED,
- false,
- true) {
-}
+ base::nullopt,
+ true) {}
HistoryAddPageArgs::HistoryAddPageArgs(const GURL& url,
base::Time time,
@@ -252,7 +251,7 @@ HistoryAddPageArgs::HistoryAddPageArgs(const GURL& url,
const RedirectList& redirects,
ui::PageTransition transition,
VisitSource source,
- bool did_replace_entry,
+ base::Optional<GURL> replaced_entry_url,
bool consider_for_ntp_most_visited)
: url(url),
time(time),
@@ -262,9 +261,8 @@ HistoryAddPageArgs::HistoryAddPageArgs(const GURL& url,
redirects(redirects),
transition(transition),
visit_source(source),
- did_replace_entry(did_replace_entry),
- consider_for_ntp_most_visited(consider_for_ntp_most_visited) {
-}
+ replaced_entry_url(replaced_entry_url),
+ consider_for_ntp_most_visited(consider_for_ntp_most_visited) {}
HistoryAddPageArgs::HistoryAddPageArgs(const HistoryAddPageArgs& other) =
default;
« no previous file with comments | « components/history/core/browser/history_types.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698