Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2948923004: Revert of [Offline Pages] Cleans up DEPS in offline_pages (Closed)

Created:
3 years, 6 months ago by fsamuel
Modified:
3 years, 6 months ago
CC:
blundell+watchlist_chromium.org, carlosk+watch_chromium.org, chili+watch_chromium.org, chromium-reviews, dewittj+watch_chromium.org, dimich+watch_chromium.org, droger+watchlist_chromium.org, fgorski+watch_chromium.org, petewil+watch_chromium.org, romax+watch_chromium.org, sdefresne+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Offline Pages] Cleans up DEPS in offline_pages (patchset #2 id:20001 of https://codereview.chromium.org/2950113002/ ) Reason for revert: This seems to have broken checkdeps Original issue's description: > [Offline Pages] Cleans up DEPS in offline_pages > > This moves DEPS into prefetch that were put on core. > > BUG=NONE > > Review-Url: https://codereview.chromium.org/2950113002 > Cr-Commit-Position: refs/heads/master@{#481555} > Committed: https://chromium.googlesource.com/chromium/src/+/4bd9a54564189647e023fce848681bfd82ca4d01 TBR=jochen@chromium.org,dimich@chromium.org,dewittj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=NONE Review-Url: https://codereview.chromium.org/2948923004 Cr-Commit-Position: refs/heads/master@{#481686} Committed: https://chromium.googlesource.com/chromium/src/+/7e9eee3af0638c3f9990b962c41f3e9b7a83bf84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/offline_pages/core/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M components/offline_pages/core/prefetch/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
fsamuel
Created Revert of [Offline Pages] Cleans up DEPS in offline_pages
3 years, 6 months ago (2017-06-22 21:53:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948923004/1
3 years, 6 months ago (2017-06-22 21:53:58 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-22 21:54:00 UTC) #5
alokp
lgtm Here is the error message: ERROR in /usr/local/google/home/alokp/src/chrome/src/components/offline_pages/core/background/connection_notifier.h Illegal include: "net/base/network_change_notifier.h" Because of no ...
3 years, 6 months ago (2017-06-22 22:04:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948923004/1
3 years, 6 months ago (2017-06-22 22:05:26 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 22:05:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e9eee3af0638c3f9990b962c41f...

Powered by Google App Engine
This is Rietveld 408576698