Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2950113002: [Offline Pages] Cleans up DEPS in offline_pages (Closed)

Created:
3 years, 6 months ago by dewittj
Modified:
3 years, 6 months ago
CC:
blundell+watchlist_chromium.org, carlosk+watch_chromium.org, chili+watch_chromium.org, chromium-reviews, dewittj+watch_chromium.org, dimich+watch_chromium.org, droger+watchlist_chromium.org, fgorski+watch_chromium.org, petewil+watch_chromium.org, romax+watch_chromium.org, sdefresne+watchlist_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Cleans up DEPS in offline_pages This moves DEPS into prefetch that were put on core. BUG=NONE Review-Url: https://codereview.chromium.org/2950113002 Cr-Commit-Position: refs/heads/master@{#481555} Committed: https://chromium.googlesource.com/chromium/src/+/4bd9a54564189647e023fce848681bfd82ca4d01

Patch Set 1 #

Patch Set 2 : DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M components/offline_pages/core/DEPS View 1 1 chunk +0 lines, -4 lines 0 comments Download
M components/offline_pages/core/prefetch/DEPS View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
dewittj
PTAL, do you think this is worth while? I can see it breaking circular dependencies ...
3 years, 6 months ago (2017-06-21 20:23:10 UTC) #7
Dmitry Titov
lgtm Increase of specificity in DEPS is good.
3 years, 6 months ago (2017-06-21 20:27:37 UTC) #8
jochen (gone - plz use gerrit)
lgtm
3 years, 6 months ago (2017-06-22 16:17:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950113002/20001
3 years, 6 months ago (2017-06-22 16:22:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2950113002/20001
3 years, 6 months ago (2017-06-22 16:31:33 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4bd9a54564189647e023fce848681bfd82ca4d01
3 years, 6 months ago (2017-06-22 16:35:20 UTC) #18
fsamuel
3 years, 6 months ago (2017-06-22 21:53:13 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2948923004/ by fsamuel@google.com.

The reason for reverting is: This seems to have broken checkdeps.

Powered by Google App Engine
This is Rietveld 408576698