Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2948893004: Add new flag for experimental app banners. (Closed)

Created:
3 years, 6 months ago by benwells
Modified:
3 years, 5 months ago
Reviewers:
Lei Zhang, Matt Giuca
CC:
chromium-reviews, asvitkine+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new flag for experimental app banners. This flag will be used to develop a new flow and modal UI for app banners on mobile and desktop. BUG=734897 Review-Url: https://codereview.chromium.org/2948893004 Cr-Commit-Position: refs/heads/master@{#482921} Committed: https://chromium.googlesource.com/chromium/src/+/0eee229999881656e25a1ebc6093caa2831535b9

Patch Set 1 #

Patch Set 2 : Enable other features if this feature enabled #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/browser/about_flags.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/banners/app_banner_manager_desktop.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_util.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/flag_descriptions.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/chrome_features.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
benwells
3 years, 6 months ago (2017-06-21 06:37:41 UTC) #8
Matt Giuca
lgtm
3 years, 6 months ago (2017-06-22 01:41:54 UTC) #9
benwells
+thestig for another, related, tiny change in chrome/renderer
3 years, 6 months ago (2017-06-22 06:56:51 UTC) #11
Lei Zhang
lgtm
3 years, 6 months ago (2017-06-22 07:25:46 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948893004/40001
3 years, 5 months ago (2017-06-28 07:19:26 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/241247) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 5 months ago (2017-06-28 07:21:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948893004/60001
3 years, 5 months ago (2017-06-28 07:33:22 UTC) #20
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 08:41:40 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0eee229999881656e25a1ebc6093...

Powered by Google App Engine
This is Rietveld 408576698