Revert of Skip missing translations when generating JSON resources.

Revert of Skip missing translations when generating JSON resources. (patchset #2 id:60001 of https://codereview.chromium.org/1676793002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 480994 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QyZjUzYmUxNjFiMDFhNGNmMDRkZmEzODdiNjZiZGE3MTBmNjAxYzAM

Original issue's description:
> Skip missing translations when generating JSON resources.
> 
> It doesn't make sense to replace missing translations with english
> strings because Chrome can do this automatically when getting
> resources.
> 
> BUG=369572
> 
> Review-Url: https://codereview.chromium.org/1676793002
> Cr-Commit-Position: refs/heads/master@{#480994}
> Committed: https://chromium.googlesource.com/chromium/src/+/d2f53be161b01a4cf04dfa387b66bda710f601c0

TBR=thakis@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369572
Review-Url: https://codereview.chromium.org/2948893002
Cr-Commit-Position: refs/heads/master@{#481003}
Committed: https://chromium.googlesource.com/chromium/src/+/4f4375e33e98c4ca5736470469638759e8b3940c

[findit-for-me, 2017-06-20 23:05:08]

Created Revert of Skip missing translations when generating JSON resources.

[findit-for-me, 2017-06-20 23:05:09]

findit-for-me@appspot.gserviceaccount.com changed reviewers:
+ dvadym@google.com, hayato@google.com, pdr@google.com, tmartino@google.com

[findit-for-me, 2017-06-20 23:05:10]

Sheriffs, CL owner or CL reviewers:

Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
If it is a false positive, please close it.

Findit (https://goo.gl/kROfz5) identified the original CL as the culprit
for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[pdr., 2017-06-20 23:05:58]

pdr@chromium.org changed reviewers:
+ pdr@chromium.org

[pdr., 2017-06-20 23:05:58]

The CQ bit was checked by pdr@chromium.org

[pdr., 2017-06-20 23:05:59]

lgtm

[commit-bot: I haz the power, 2017-06-20 23:06:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 23:06:44]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1497999958878770, "parent_rev":
"2709eee26ac162dc961a19bed779a584bb49da02", "commit_rev":
"4f4375e33e98c4ca5736470469638759e8b3940c"}

[commit-bot: I haz the power, 2017-06-20 23:07:00]

Description was changed from

==========
Revert of Skip missing translations when generating JSON resources. (patchset #2
id:60001 of https://codereview.chromium.org/1676793002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 480994 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Skip missing translations when generating JSON resources.
> 
> It doesn't make sense to replace missing translations with english
> strings because Chrome can do this automatically when getting
> resources.
> 
> BUG=369572
> 
> Review-Url: https://codereview.chromium.org/1676793002
> Cr-Commit-Position: refs/heads/master@{#480994}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d2f53be161b01a4cf04dfa387b66...

TBR=thakis@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369572
==========

to

==========
Revert of Skip missing translations when generating JSON resources. (patchset #2
id:60001 of https://codereview.chromium.org/1676793002/ )

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 480994 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

Original issue's description:
> Skip missing translations when generating JSON resources.
> 
> It doesn't make sense to replace missing translations with english
> strings because Chrome can do this automatically when getting
> resources.
> 
> BUG=369572
> 
> Review-Url: https://codereview.chromium.org/1676793002
> Cr-Commit-Position: refs/heads/master@{#480994}
> Committed:
https://chromium.googlesource.com/chromium/src/+/d2f53be161b01a4cf04dfa387b66...

TBR=thakis@chromium.org,sergeyu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369572

Review-Url: https://codereview.chromium.org/2948893002
Cr-Commit-Position: refs/heads/master@{#481003}
Committed:
https://chromium.googlesource.com/chromium/src/+/4f4375e33e98c4ca573647046963...
==========

[commit-bot: I haz the power, 2017-06-20 23:07:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f4375e33e98c4ca573647046963...

[findit-for-me, 2017-06-28 01:06:25]

findit-for-me@appspot.gserviceaccount.com changed reviewers:
+ benwells@google.com, engedy@google.com, msw@google.com, rouslan@google.com

[findit-for-me, 2017-06-28 01:06:26]

Sheriffs, CL owner or CL reviewers:

Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
If it is a false positive, please close it.

Findit (https://goo.gl/kROfz5) identified the original CL as the culprit
for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[pdr., 2017-06-28 01:14:08]

On 2017/06/28 at 01:06:26, findit-for-me wrote:
> Sheriffs, CL owner or CL reviewers:
> 
> Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
> If it is a false positive, please close it.
> 
> Findit (https://goo.gl/kROfz5) identified the original CL as the culprit
> for failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

It looks like findit re-uses old reverts? I don't think we should re-land this
because this was reverted manually in another patch:
https://codereview.chromium.org/2960853003/

[benwells, 2017-06-28 01:25:53]

On 2017/06/28 01:14:08, pdr. wrote:
> On 2017/06/28 at 01:06:26, findit-for-me wrote:
> > Sheriffs, CL owner or CL reviewers:
> > 
> > Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
> > If it is a false positive, please close it.
> > 
> > Findit (https://goo.gl/kROfz5) identified the original CL as the culprit
> > for failures in the build cycles as shown on:
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> It looks like findit re-uses old reverts? I don't think we should re-land this
> because this was reverted manually in another patch:
> https://codereview.chromium.org/2960853003/

Oh wow this is confusing, this revert was landed a week ago already, and findit
it is reusing it. But another revert has landed anyway. wow.

I agree, we should close this. I'll do so now.

[benwells, 2017-06-28 01:26:12]

On 2017/06/28 01:25:53, benwells wrote:
> On 2017/06/28 01:14:08, pdr. wrote:
> > On 2017/06/28 at 01:06:26, findit-for-me wrote:
> > > Sheriffs, CL owner or CL reviewers:
> > > 
> > > Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
> > > If it is a false positive, please close it.
> > > 
> > > Findit (https://goo.gl/kROfz5) identified the original CL as the culprit
> > > for failures in the build cycles as shown on:
> > >
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> > 
> > It looks like findit re-uses old reverts? I don't think we should re-land
this
> > because this was reverted manually in another patch:
> > https://codereview.chromium.org/2960853003/
> 
> Oh wow this is confusing, this revert was landed a week ago already, and
findit
> it is reusing it. But another revert has landed anyway. wow.
> 
> I agree, we should close this. I'll do so now.

Or I won't because it is already closed :)

[Nico, 2017-06-28 01:45:46]

Can someone file a findit bug?

On Jun 27, 2017 9:26 PM, <benwells@chromium.org> wrote:

> On 2017/06/28 01:25:53, benwells wrote:
> > On 2017/06/28 01:14:08, pdr. wrote:
> > > On 2017/06/28 at 01:06:26, findit-for-me wrote:
> > > > Sheriffs, CL owner or CL reviewers:
> > > >
> > > > Please confirm and "Quick L-G-T-M & CQ" this revert if it is correct.
> > > > If it is a false positive, please close it.
> > > >
> > > > Findit (https://goo.gl/kROfz5) identified the original CL as the
> culprit
> > > > for failures in the build cycles as shown on:
> > > >
> > >
> >
> https://findit-for-me.appspot.com/waterfall/culprit?key=
> ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVt
> LzFkZWFlYmQyOTdiNzIxMjkzMmJlNGFmZTM0YWUwYjYwYzQ1YmQ5ZmQM
> > >
> > > It looks like findit re-uses old reverts? I don't think we should
> re-land
> this
> > > because this was reverted manually in another patch:
> > > https://codereview.chromium.org/2960853003/
> >
> > Oh wow this is confusing, this revert was landed a week ago already, and
> findit
> > it is reusing it. But another revert has landed anyway. wow.
> >
> > I agree, we should close this. I'll do so now.
>
> Or I won't because it is already closed :)
>
> https://codereview.chromium.org/2948893002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sergey Ulanov, 2017-06-28 01:50:50]

FWIW I used the same rietveld issue for the reland, which was the problem
here. With gerrit I would have to a separate CL, so this looks like
rietveld-specific bug.

On Tue, Jun 27, 2017 at 6:45 PM, Nico Weber <thakis@chromium.org> wrote:

> Can someone file a findit bug?
>

> On Jun 27, 2017 9:26 PM, <benwells@chromium.org> wrote:
>
>> On 2017/06/28 01:25:53, benwells wrote:
>> > On 2017/06/28 01:14:08, pdr. wrote:
>> > > On 2017/06/28 at 01:06:26, findit-for-me wrote:
>> > > > Sheriffs, CL owner or CL reviewers:
>> > > >
>> > > > Please confirm and "Quick L-G-T-M & CQ" this revert if it is
>> correct.
>> > > > If it is a false positive, please close it.
>> > > >
>> > > > Findit (https://goo.gl/kROfz5) identified the original CL as the
>> culprit
>> > > > for failures in the build cycles as shown on:
>> > > >
>> > >
>> >
>> https://findit-for-me.appspot.com/waterfall/culprit?key=ag9z
>> fmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzFk
>> ZWFlYmQyOTdiNzIxMjkzMmJlNGFmZTM0YWUwYjYwYzQ1YmQ5ZmQM
>> > >
>> > > It looks like findit re-uses old reverts? I don't think we should
>> re-land
>> this
>> > > because this was reverted manually in another patch:
>> > > https://codereview.chromium.org/2960853003/
>> >
>> > Oh wow this is confusing, this revert was landed a week ago already, and
>> findit
>> > it is reusing it. But another revert has landed anyway. wow.
>> >
>> > I agree, we should close this. I'll do so now.
>>
>> Or I won't because it is already closed :)
>>
>> https://codereview.chromium.org/2948893002/
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.