Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2960853003: Revert of Skip missing translations when generating JSON resources. (Closed)

Created:
3 years, 5 months ago by Sergey Ulanov
Modified:
3 years, 5 months ago
Reviewers:
Nico
CC:
chromium-reviews, Jamie
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Skip missing translations when generating JSON resources. (patchset #2 id:60001 of https://codereview.chromium.org/1676793002/ ) Reason for revert: Broke windows build: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Builder%2F86539%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original issue's description: > Skip missing translations when generating JSON resources. > > It doesn't make sense to replace missing translations with english > strings because Chrome can do this automatically when getting > resources. > > BUG=369572 > > Review-Url: https://codereview.chromium.org/1676793002 > Cr-Original-Commit-Position: refs/heads/master@{#480994} > Committed: https://chromium.googlesource.com/chromium/src/+/d2f53be161b01a4cf04dfa387b66bda710f601c0 > Review-Url: https://codereview.chromium.org/1676793002 > Cr-Commit-Position: refs/heads/master@{#482826} > Committed: https://chromium.googlesource.com/chromium/src/+/1deaebd297b7212932be4afe34ae0b60c45bd9fd TBR=thakis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=369572 Review-Url: https://codereview.chromium.org/2960853003 Cr-Commit-Position: refs/heads/master@{#482830} Committed: https://chromium.googlesource.com/chromium/src/+/5ff277be982f4deb8828f743633dfa5f54824e92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -33 lines) Patch
M tools/grit/grit/format/chrome_messages_json.py View 2 chunks +1 line, -6 lines 0 comments Download
M tools/grit/grit/format/chrome_messages_json_unittest.py View 2 chunks +1 line, -27 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Sergey Ulanov
Created Revert of Skip missing translations when generating JSON resources.
3 years, 5 months ago (2017-06-28 01:00:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2960853003/1
3 years, 5 months ago (2017-06-28 01:01:09 UTC) #3
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 01:01:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ff277be982f4deb8828f743633d...

Powered by Google App Engine
This is Rietveld 408576698