DescriptionRevert of Skip missing translations when generating JSON resources. (patchset #2 id:60001 of https://codereview.chromium.org/1676793002/ )
Reason for revert:
Broke windows build: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.linux%2FLinux_Builder%2F86539%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout
Original issue's description:
> Skip missing translations when generating JSON resources.
>
> It doesn't make sense to replace missing translations with english
> strings because Chrome can do this automatically when getting
> resources.
>
> BUG=369572
>
> Review-Url: https://codereview.chromium.org/1676793002
> Cr-Original-Commit-Position: refs/heads/master@{#480994}
> Committed: https://chromium.googlesource.com/chromium/src/+/d2f53be161b01a4cf04dfa387b66bda710f601c0
> Review-Url: https://codereview.chromium.org/1676793002
> Cr-Commit-Position: refs/heads/master@{#482826}
> Committed: https://chromium.googlesource.com/chromium/src/+/1deaebd297b7212932be4afe34ae0b60c45bd9fd
TBR=thakis@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369572
Review-Url: https://codereview.chromium.org/2960853003
Cr-Commit-Position: refs/heads/master@{#482830}
Committed: https://chromium.googlesource.com/chromium/src/+/5ff277be982f4deb8828f743633dfa5f54824e92
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|