Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 2948793002: crazy linker: Expand isnanf workaround to all platforms. (Closed)

Created:
3 years, 6 months ago by Nico
Modified:
3 years, 6 months ago
CC:
chromium-reviews, johnmaguire+watch_google.com
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

crazy linker: Expand isnanf workaround to all platforms. BUG=735003 TBR=rmcilroy Review-Url: https://codereview.chromium.org/2948793002 Cr-Commit-Position: refs/heads/master@{#480856} Committed: https://chromium.googlesource.com/chromium/src/+/2493094e61e2e477a2ea48ff8c2e63711b422904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/android_crazy_linker/src/src/crazy_linker_shared_library.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Nico
I don't have an x86 device to actually test this :-/
3 years, 6 months ago (2017-06-20 15:38:24 UTC) #3
Nico
QA verified that this helps. Ross, I'll TBR this since it's for a dev blocker, ...
3 years, 6 months ago (2017-06-20 16:43:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948793002/1
3 years, 6 months ago (2017-06-20 16:43:57 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 16:48:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2493094e61e2e477a2ea48ff8c2e...

Powered by Google App Engine
This is Rietveld 408576698