Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: third_party/android_crazy_linker/src/src/crazy_linker_shared_library.cpp

Issue 2948793002: crazy linker: Expand isnanf workaround to all platforms. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/android_crazy_linker/src/src/crazy_linker_shared_library.cpp
diff --git a/third_party/android_crazy_linker/src/src/crazy_linker_shared_library.cpp b/third_party/android_crazy_linker/src/src/crazy_linker_shared_library.cpp
index b982a7d63cf65a9335e0919b59897e34ccfe29a9..f9abd66240b453fe808ad701de04f5e897b1bb49 100644
--- a/third_party/android_crazy_linker/src/src/crazy_linker_shared_library.cpp
+++ b/third_party/android_crazy_linker/src/src/crazy_linker_shared_library.cpp
@@ -146,7 +146,6 @@ class SharedLibraryResolver : public ElfRelocations::SymbolResolver {
virtual void* LookupInWrap(const char* symbol_name, LibraryView* wrap) {
if (wrap->IsSystem()) {
void* address = ::dlsym(wrap->GetSystem(), symbol_name);
-#ifdef __arm__
// Android libm.so defines isnanf as weak. This means that its
// address cannot be found by dlsym(), which returns NULL for weak
// symbols prior to Android 5.0. However, libm.so contains the real
@@ -162,7 +161,6 @@ class SharedLibraryResolver : public ElfRelocations::SymbolResolver {
!strcmp(symbol_name, "isnanf") &&
!strcmp(wrap->GetName(), "libm.so"))
address = ::dlsym(wrap->GetSystem(), "__isnanf");
-#endif
return address;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698