Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2948753003: Revert of Fix Harmony checkbox having an ink drop highlight on click. (Closed)

Created:
3 years, 6 months ago by Bret
Modified:
3 years, 6 months ago
Reviewers:
sky, bruthig
CC:
chromium-reviews, tfarina, bruthig
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix Harmony checkbox having an ink drop highlight on click. (patchset #1 id:1 of https://codereview.chromium.org/2939043005/ ) Reason for revert: Breaks Chrome OS x86. Original issue's description: > Fix Harmony checkbox having an ink drop highlight on click. > > Follow-up to crrev.com/2911573002. There was a regression with a later > refactor of the ink drop code, and this fixes that. > > BUG=652510 > > Review-Url: https://codereview.chromium.org/2939043005 > Cr-Commit-Position: refs/heads/master@{#480958} > Committed: https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b395bb60842273f TBR=sky@chromium.org,bruthig@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=652510 Review-Url: https://codereview.chromium.org/2948753003 Cr-Commit-Position: refs/heads/master@{#481074} Committed: https://chromium.googlesource.com/chromium/src/+/5651a37f2caccaaaae395438195c3eced402e3a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ui/views/controls/button/checkbox.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Bret
Created Revert of Fix Harmony checkbox having an ink drop highlight on click.
3 years, 6 months ago (2017-06-21 01:43:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948753003/1
3 years, 6 months ago (2017-06-21 01:43:32 UTC) #3
commit-bot: I haz the power
3 years, 6 months ago (2017-06-21 01:44:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5651a37f2caccaaaae395438195c...

Powered by Google App Engine
This is Rietveld 408576698