Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2939043005:
Fix Harmony checkbox having an ink drop highlight on click. (Closed)
DescriptionFix Harmony checkbox having an ink drop highlight on click.
Follow-up to crrev.com/2911573002. There was a regression with a later
refactor of the ink drop code, and this fixes that.
BUG=652510
Review-Url: https://codereview.chromium.org/2939043005
Cr-Original-Commit-Position: refs/heads/master@{#480958}
Committed: https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b395bb60842273f
Review-Url: https://codereview.chromium.org/2939043005
Cr-Commit-Position: refs/heads/master@{#481639}
Committed: https://chromium.googlesource.com/chromium/src/+/037435e4c3f4ed899e609a948feeb3aa6957ffd1
Patch Set 1 #
Messages
Total messages: 31 (17 generated)
The CQ bit was checked by bsep@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Fix Harmony checkbox having an ink drop highlight on click. Follow-up to crrev.com/2911573002. There was a regression with a later refactor of the ink drop code, and this fixes that. BUG=652510 ========== to ========== Fix Harmony checkbox having an ink drop highlight on click. Follow-up to crrev.com/2911573002. There was a regression with a later refactor of the ink drop code, and this fixes that. BUG=652510 ==========
bsep@chromium.org changed reviewers: + sky@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
sky@chromium.org changed reviewers: + bruthig@chromium.org
LGTM
The CQ bit was checked by bsep@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by bsep@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497988758228090, "parent_rev":
"454efabee965715cf3a8ed20854455163cfc03b2", "commit_rev":
"945f2f94b22139061408b8a8e4e24754531c31a6"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1497988758228090, "parent_rev":
"a6e513ff4e69d0f016e74b2ddbd671b814172968", "commit_rev":
"6be568e4976c957d72d685a18b395bb60842273f"}
Message was sent while issue was closed.
Description was changed from ========== Fix Harmony checkbox having an ink drop highlight on click. Follow-up to crrev.com/2911573002. There was a regression with a later refactor of the ink drop code, and this fixes that. BUG=652510 ========== to ========== Fix Harmony checkbox having an ink drop highlight on click. Follow-up to crrev.com/2911573002. There was a regression with a later refactor of the ink drop code, and this fixes that. BUG=652510 Review-Url: https://codereview.chromium.org/2939043005 Cr-Commit-Position: refs/heads/master@{#480958} Committed: https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b39... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b39...
Message was sent while issue was closed.
On 2017/06/20 21:25:07, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b39... Getting the following error on a Chrome OS builder: ../../ui/views/controls/button/checkbox.cc:150:10: error: cannot bind 'std::unique_ptr<views::InkDropImpl>' lvalue to 'std::unique_ptr<views::InkDropImpl>&&' return ink_drop; Builder: https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-ge... Not sure why this din't show up in the CQ. Looking to repo locally and verify that a revert fixes the errir.
Message was sent while issue was closed.
On 2017/06/20 23:13:53, stevenjb wrote: > On 2017/06/20 21:25:07, commit-bot: I haz the power wrote: > > Committed patchset #1 (id:1) as > > > https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b39... > > Getting the following error on a Chrome OS builder: > ../../ui/views/controls/button/checkbox.cc:150:10: error: cannot bind > 'std::unique_ptr<views::InkDropImpl>' lvalue to > 'std::unique_ptr<views::InkDropImpl>&&' > return ink_drop; > > Builder: > https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-ge... > > Not sure why this din't show up in the CQ. Looking to repo locally and verify > that a revert fixes the errir. This may be a weird toolchain issue; we don't support x86 builders anymore, so nevermind.
Message was sent while issue was closed.
On 2017/06/21 at 00:07:20, stevenjb wrote: > On 2017/06/20 23:13:53, stevenjb wrote: > > On 2017/06/20 21:25:07, commit-bot: I haz the power wrote: > > > Committed patchset #1 (id:1) as > > > > > https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b39... > > > > Getting the following error on a Chrome OS builder: > > ../../ui/views/controls/button/checkbox.cc:150:10: error: cannot bind > > 'std::unique_ptr<views::InkDropImpl>' lvalue to > > 'std::unique_ptr<views::InkDropImpl>&&' > > return ink_drop; > > > > Builder: > > https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-ge... > > > > Not sure why this din't show up in the CQ. Looking to repo locally and verify > > that a revert fixes the errir. > > This may be a weird toolchain issue; we don't support x86 builders anymore, so nevermind. I am also seeing this on the ChromeOS builder: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FCh... Can we revert this patch to green that builder?
Message was sent while issue was closed.
On 2017/06/21 at 00:56:35, pdr. wrote: > On 2017/06/21 at 00:07:20, stevenjb wrote: > > On 2017/06/20 23:13:53, stevenjb wrote: > > > On 2017/06/20 21:25:07, commit-bot: I haz the power wrote: > > > > Committed patchset #1 (id:1) as > > > > > > > https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b39... > > > > > > Getting the following error on a Chrome OS builder: > > > ../../ui/views/controls/button/checkbox.cc:150:10: error: cannot bind > > > 'std::unique_ptr<views::InkDropImpl>' lvalue to > > > 'std::unique_ptr<views::InkDropImpl>&&' > > > return ink_drop; > > > > > > Builder: > > > https://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20x86-ge... > > > > > > Not sure why this din't show up in the CQ. Looking to repo locally and verify > > > that a revert fixes the errir. > > > > This may be a weird toolchain issue; we don't support x86 builders anymore, so nevermind. > > I am also seeing this on the ChromeOS builder: > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FCh... > > Can we revert this patch to green that builder? I filed https://crbug.com/735293 to track this.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2948753003/ by bsep@chromium.org. The reason for reverting is: Breaks Chrome OS x86..
Message was sent while issue was closed.
Description was changed from ========== Fix Harmony checkbox having an ink drop highlight on click. Follow-up to crrev.com/2911573002. There was a regression with a later refactor of the ink drop code, and this fixes that. BUG=652510 Review-Url: https://codereview.chromium.org/2939043005 Cr-Commit-Position: refs/heads/master@{#480958} Committed: https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b39... ========== to ========== Fix Harmony checkbox having an ink drop highlight on click. Follow-up to crrev.com/2911573002. There was a regression with a later refactor of the ink drop code, and this fixes that. BUG=652510 Review-Url: https://codereview.chromium.org/2939043005 Cr-Commit-Position: refs/heads/master@{#480958} Committed: https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b39... ==========
On 2017/06/21 01:43:01, Bret wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2948753003/ by mailto:bsep@chromium.org. > > The reason for reverting is: Breaks Chrome OS x86.. Relanding. The broken builder has been removed from the waterfall (https://codereview.chromium.org/2952773002).
The CQ bit was checked by bsep@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1498157027441920, "parent_rev":
"8309dd9de3baa6a3897d3b1fe094e26846f9bad8", "commit_rev":
"037435e4c3f4ed899e609a948feeb3aa6957ffd1"}
Message was sent while issue was closed.
Description was changed from ========== Fix Harmony checkbox having an ink drop highlight on click. Follow-up to crrev.com/2911573002. There was a regression with a later refactor of the ink drop code, and this fixes that. BUG=652510 Review-Url: https://codereview.chromium.org/2939043005 Cr-Commit-Position: refs/heads/master@{#480958} Committed: https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b39... ========== to ========== Fix Harmony checkbox having an ink drop highlight on click. Follow-up to crrev.com/2911573002. There was a regression with a later refactor of the ink drop code, and this fixes that. BUG=652510 Review-Url: https://codereview.chromium.org/2939043005 Cr-Original-Commit-Position: refs/heads/master@{#480958} Committed: https://chromium.googlesource.com/chromium/src/+/6be568e4976c957d72d685a18b39... Review-Url: https://codereview.chromium.org/2939043005 Cr-Commit-Position: refs/heads/master@{#481639} Committed: https://chromium.googlesource.com/chromium/src/+/037435e4c3f4ed899e609a948fee... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/037435e4c3f4ed899e609a948fee... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
