[LayoutNG] Let NGLineBreaker pass line box location to NGInlineLayoutAlgorithm

[LayoutNG] Let NGLineBreaker pass line box location to NGInlineLayoutAlgorithm

Now that NGLineBreaker knows layout opportunities and BFC offset and
computes line box positions for floats, this patch passes the
information to NGInlineLayoutAlgorithm to avoid re-compute.

This will also allow NGLineBreaker to set line-top, which will be needed
when it needs to push lines down; e.g., when it find 100% width floats.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2948743002
Cr-Commit-Position: refs/heads/master@{#481126}
Committed: https://chromium.googlesource.com/chromium/src/+/99455058b030b33f127b6d0e897c2d13c955400a

[kojii, 2017-06-20 08:49:31]

Description was changed from

==========
lineloc

BUG=
==========

to

==========
lineloc

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-06-20 17:28:44]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 17:29:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2017-06-20 17:33:23]

Description was changed from

==========
lineloc

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Let NGLineBreaker pass line box location to NGInlineLayoutAlgorithm

Now that NGLineBreaker knows layout opportunities and BFC offset and
computes line box positions for floats, this patch passes the
information to NGInlineLayoutAlgorithm to avoid re-compute.

This will also allow NGLineBreaker to set line-top, which will be needed
when it needs to push lines down; e.g., when it find 100% width floats.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

[kojii, 2017-06-20 17:39:29]

kojii@chromium.org changed reviewers:
+ ikilpatrick@chromium.org

[kojii, 2017-06-20 17:39:30]

PTAL. This is on top of the other CL.

[kojii, 2017-06-20 17:45:54]

Is "100% width floats" what you were talking about today? If so, it's on my
radar but not done yet.

[commit-bot: I haz the power, 2017-06-20 20:16:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 20:16:45]

Dry run: This issue passed the CQ dry run.

[ikilpatrick, 2017-06-20 23:54:31]

On 2017/06/20 17:45:54, kojii wrote:
> Is "100% width floats" what you were talking about today? If so, it's on my
> radar but not done yet.

lgtm, 

it was actually for this case:
https://www.software.hixie.ch/utilities/js/live-dom-viewer/?%3C!DOCTYPE%20htm...

I.e. the atomic inline is the first item in the line which makes the line-box be
constructed. But it immediately overflows the initial layout opportunity, so we
need to search for the next.

Does that make sense?

[ikilpatrick, 2017-06-20 23:54:39]

https://codereview.chromium.org/2948743002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc
(right):

https://codereview.chromium.org/2948743002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc:219:
// NGLineBreaker should have determined we need a line box, and that has
newline above this for spacing?

[kojii, 2017-06-21 03:30:39]

On 2017/06/20 at 23:54:31, ikilpatrick wrote:
> it was actually for this case:
>
https://www.software.hixie.ch/utilities/js/live-dom-viewer/?%3C!DOCTYPE%20htm...
> 
> I.e. the atomic inline is the first item in the line which makes the line-box
be constructed. But it immediately overflows the initial layout opportunity, so
we need to search for the next.
> 
> Does that make sense?

Yes, that's the same one I'm talking about. I fixed this in legacy line breaker,
and one of wpt test fails for the lack of this.

It's in my backlog, but feel free to take if you'd like ;)

[kojii, 2017-06-21 03:44:25]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 03:44:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 06:01:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 06:01:58]

Dry run: This issue passed the CQ dry run.

[kojii, 2017-06-21 06:36:21]

The CQ bit was checked by kojii@chromium.org

[kojii, 2017-06-21 06:36:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
ikilpatrick@chromium.org
Link to the patchset: https://codereview.chromium.org/2948743002/#ps80001
(title: "ikilpatrick review")

[commit-bot: I haz the power, 2017-06-21 06:36:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 06:41:31]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1498026981057570,
"parent_rev": "9cea65766cfffee8db51e2f6edb694e0fe10ef93", "commit_rev":
"99455058b030b33f127b6d0e897c2d13c955400a"}

[commit-bot: I haz the power, 2017-06-21 06:41:44]

Description was changed from

==========
[LayoutNG] Let NGLineBreaker pass line box location to NGInlineLayoutAlgorithm

Now that NGLineBreaker knows layout opportunities and BFC offset and
computes line box positions for floats, this patch passes the
information to NGInlineLayoutAlgorithm to avoid re-compute.

This will also allow NGLineBreaker to set line-top, which will be needed
when it needs to push lines down; e.g., when it find 100% width floats.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng
==========

to

==========
[LayoutNG] Let NGLineBreaker pass line box location to NGInlineLayoutAlgorithm

Now that NGLineBreaker knows layout opportunities and BFC offset and
computes line box positions for floats, this patch passes the
information to NGInlineLayoutAlgorithm to avoid re-compute.

This will also allow NGLineBreaker to set line-top, which will be needed
when it needs to push lines down; e.g., when it find 100% width floats.

BUG=636993
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng

Review-Url: https://codereview.chromium.org/2948743002
Cr-Commit-Position: refs/heads/master@{#481126}
Committed:
https://chromium.googlesource.com/chromium/src/+/99455058b030b33f127b6d0e897c...
==========

[commit-bot: I haz the power, 2017-06-21 06:41:46]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/99455058b030b33f127b6d0e897c...