third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h - Issue 2948743002: [LayoutNG] Let NGLineBreaker pass line box location to NGInlineLayoutAlgorithm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h

Issue 2948743002: [LayoutNG] Let NGLineBreaker pass line box location to NGInlineLayoutAlgorithm (Closed)

Patch Set: ikilpatrick review Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_inline_item_result.cc ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h

index fb497859c4bdabab3e4eb55d5481b522efdbc134..805f944f1f7bc6af14c4df7e62aa5da1c61ebc87 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_inline_layout_algorithm.h

@@ -50,8 +50,6 @@ class CORE_EXPORT NGInlineLayoutAlgorithm final

private:

bool IsHorizontalWritingMode() const { return is_horizontal_writing_mode_; }

- LayoutUnit LogicalLeftOffset(const NGLayoutOpportunity&) const;

void BidiReorder(NGInlineItemResults*);

bool PlaceItems(NGLineInfo*, RefPtr<NGInlineBreakToken>);

@@ -69,8 +67,6 @@ class CORE_EXPORT NGInlineLayoutAlgorithm final

LayoutUnit ComputeContentSize(const NGLineInfo&, LayoutUnit line_bottom);

- NGLayoutOpportunity FindLayoutOpportunityForLine();

NGInlineLayoutStateStack box_states_;

LayoutUnit content_size_;

LayoutUnit max_inline_size_;