Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 2948513003: Revert of ozone/drm: Only reuse ScanoutBuffers with compatible modifiers (Closed)

Created:
3 years, 6 months ago by marcheu1
Modified:
3 years, 6 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ozone/drm: Only reuse ScanoutBuffers with compatible modifiers (patchset #4 id:60001 of https://codereview.chromium.org/2919533003/ ) Reason for revert: This breaks nyan (see crbug.com/734074) so let's revert to hopefully have a green PFQ run today. Original issue's description: > ozone/drm: Only reuse ScanoutBuffers with compatible modifiers > > Now that we have modifiers, we need to make sure that not just the > format, but also the format modifer is compatible with the > HardwareDisplayController where we want to use the buffer. > > BUG=b/38217940 > TEST=Plug in external monitor that supports same resolution as internal > panel with mirror mode enabled > > Review-Url: https://codereview.chromium.org/2919533003 > Cr-Commit-Position: refs/heads/master@{#479813} > Committed: https://chromium.googlesource.com/chromium/src/+/9947afe90294ff5ad902e2cc02f8064506f7f0a4 TBR=dcastagna@chromium.org,reveman@chromium.org,dnicoara@chromium.org,hoegsberg@google.com,hoegsberg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=b/38217940 Review-Url: https://codereview.chromium.org/2948513003 Cr-Commit-Position: refs/heads/master@{#480683} Committed: https://chromium.googlesource.com/chromium/src/+/d4a230f60cc702283992d180a1cd77109d8459bd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -119 lines) Patch
M ui/ozone/platform/drm/gpu/drm_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_buffer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer.cc View 3 chunks +7 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer_base.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/gbm_buffer_base.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_hardware_display_plane_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer.h View 3 chunks +1 line, -7 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer.cc View 2 chunks +4 lines, -22 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/ozone/platform/drm/gpu/mock_scanout_buffer_generator.cc View 1 chunk +1 line, -10 lines 0 comments Download
M ui/ozone/platform/drm/gpu/scanout_buffer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager.cc View 1 chunk +6 lines, -19 lines 0 comments Download
M ui/ozone/platform/drm/gpu/screen_manager_unittest.cc View 4 chunks +4 lines, -35 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
marcheu1
Created Revert of ozone/drm: Only reuse ScanoutBuffers with compatible modifiers
3 years, 6 months ago (2017-06-19 23:40:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948513003/1
3 years, 6 months ago (2017-06-19 23:41:14 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-19 23:41:17 UTC) #5
marcheu
On 2017/06/19 23:41:17, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 6 months ago (2017-06-19 23:42:43 UTC) #6
ilja
LGTM
3 years, 6 months ago (2017-06-19 23:43:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948513003/1
3 years, 6 months ago (2017-06-19 23:43:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/d4a230f60cc702283992d180a1cd77109d8459bd
3 years, 6 months ago (2017-06-20 01:47:41 UTC) #12
hoegsberg1
3 years, 6 months ago (2017-06-20 17:59:54 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2951803002/ by hoegsberg@google.com.

The reason for reverting is: Let's revert the revert and land the fix:

https://chromium-review.googlesource.com/c/540817/?polygerrit=1.

Powered by Google App Engine
This is Rietveld 408576698