Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2948093002: ChromeOS OOBE: rename and add new attributes to oobe-dialog (Closed)

Created:
3 years, 6 months ago by Alexander Alekseev
Modified:
3 years, 6 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: rename and add new attributes to oobe-dialog BUG=709244 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2948093002 Cr-Commit-Position: refs/heads/master@{#481414} Committed: https://chromium.googlesource.com/chromium/src/+/b09b0917566ee9e1c9d807652223e57c3078b9f2

Patch Set 1 #

Patch Set 2 : Style #

Patch Set 3 : Cleanup #

Patch Set 4 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_dialog.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_dialog.html View 2 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_dialog.js View 1 2 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_voice_interaction_value_prop.html View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
Alexander Alekseev
Please review.
3 years, 6 months ago (2017-06-21 16:04:06 UTC) #5
achuithb
lgtm
3 years, 6 months ago (2017-06-21 18:35:02 UTC) #10
commit-bot: I haz the power
This CL has an open dependency (Issue 2946023002 Patch 20001). Please resolve the dependency and ...
3 years, 6 months ago (2017-06-21 20:07:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2948093002/60001
3 years, 6 months ago (2017-06-22 00:08:03 UTC) #16
commit-bot: I haz the power
3 years, 6 months ago (2017-06-22 02:44:28 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b09b0917566ee9e1c9d807652223...

Powered by Google App Engine
This is Rietveld 408576698