ChromeOS: Add support for loading GAIA API v2

ChromeOS: Add support for loading GAIA API v2

This CL adds ability to load GAIA API v2 endpoint.

BUG=709244
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2946023002
Cr-Commit-Position: refs/heads/master@{#481365}
Committed: https://chromium.googlesource.com/chromium/src/+/bf908dfad4cf7840c2eedd7e4c88009430238428

[Alexander Alekseev, 2017-06-20 16:00:18]

Description was changed from

==========
ChromeOS: Add support for loading GAIA API v2

This CL adds ability to load GAIA API v2 endpoint.

BUG=709244
==========

to

==========
ChromeOS: Add support for loading GAIA API v2

This CL adds ability to load GAIA API v2 endpoint.

BUG=709244
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Alexander Alekseev, 2017-06-20 16:01:08]

alemate@chromium.org changed reviewers:
+ achuith@chromium.org

[Alexander Alekseev, 2017-06-20 16:01:09]

Please review.

[Alexander Alekseev, 2017-06-20 16:01:14]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 16:01:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexander Alekseev, 2017-06-20 16:02:34]

Please note that this CL still defaults to old (v1) API.

[commit-bot: I haz the power, 2017-06-20 17:11:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 17:11:22]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Alexander Alekseev, 2017-06-20 17:23:52]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-20 17:24:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-20 18:04:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-20 18:04:56]

Dry run: This issue passed the CQ dry run.

[achuithb, 2017-06-21 18:33:12]

lgtm

https://codereview.chromium.org/2946023002/diff/1/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/2946023002/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:267: if
(this.chromeOSApiVersion_ && this.chromeOSApiVersion_ == 2) {
Can drop {}

https://codereview.chromium.org/2946023002/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:297: if (data.gaiaPath)
{
can drop {}

https://codereview.chromium.org/2946023002/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:299: } else if
(this.isNewGaiaFlow) {
This is always true, right? Should we deprecate this?

[Alexander Alekseev, 2017-06-21 20:05:35]

https://codereview.chromium.org/2946023002/diff/1/chrome/browser/resources/ga...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/2946023002/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:267: if
(this.chromeOSApiVersion_ && this.chromeOSApiVersion_ == 2) {
On 2017/06/21 18:33:12, achuithb wrote:
> Can drop {}

Done.

https://codereview.chromium.org/2946023002/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:297: if (data.gaiaPath)
{
On 2017/06/21 18:33:12, achuithb wrote:
> can drop {}

Done.

https://codereview.chromium.org/2946023002/diff/1/chrome/browser/resources/ga...
chrome/browser/resources/gaia_auth_host/authenticator.js:299: } else if
(this.isNewGaiaFlow) {
On 2017/06/21 18:33:12, achuithb wrote:
> This is always true, right? Should we deprecate this?

isNewGaiaFlow should be either removed or renamed to isChromeOs.

I quickly looked through the code, but did not understand whether this object is
used on a desktop or not. So I decided to postpone this to a separate CL ;)

[Alexander Alekseev, 2017-06-21 20:06:02]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2017-06-21 20:06:02]

The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/2946023002/#ps20001
(title: "Update after review")

[commit-bot: I haz the power, 2017-06-21 20:06:25]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 21:21:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 21:21:37]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Alexander Alekseev, 2017-06-21 23:15:43]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-21 23:15:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-21 23:53:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-21 23:53:25]

Dry run: This issue passed the CQ dry run.

[Alexander Alekseev, 2017-06-22 00:02:05]

The CQ bit was checked by alemate@chromium.org

[commit-bot: I haz the power, 2017-06-22 00:02:21]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 00:06:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498089725700340,
"parent_rev": "16583bd29983624a113b0597bda0096459f416e9", "commit_rev":
"bf908dfad4cf7840c2eedd7e4c88009430238428"}

[commit-bot: I haz the power, 2017-06-22 00:07:03]

Description was changed from

==========
ChromeOS: Add support for loading GAIA API v2

This CL adds ability to load GAIA API v2 endpoint.

BUG=709244
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS: Add support for loading GAIA API v2

This CL adds ability to load GAIA API v2 endpoint.

BUG=709244
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2946023002
Cr-Commit-Position: refs/heads/master@{#481365}
Committed:
https://chromium.googlesource.com/chromium/src/+/bf908dfad4cf7840c2eedd7e4c88...
==========

[commit-bot: I haz the power, 2017-06-22 00:07:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bf908dfad4cf7840c2eedd7e4c88...