Android: Add exclude_xxxhdpi GN parameter to android_apk

Android: Add exclude_xxxhdpi GN parameter to android_apk()

Plan to enable the flag in chrome_apk_tmpl in a follow-up.

BUG=691733
Review-Url: https://codereview.chromium.org/2948083003
Cr-Commit-Position: refs/heads/master@{#481619}
Committed: https://chromium.googlesource.com/chromium/src/+/8843ff4c2a8bde44bf19dadb661f3b089aacc2e1

[agrieve, 2017-06-22 14:32:50]

Description was changed from

==========
Android: Stop shipping xxxhdpi images

Turns out the gains in image quality are almost unnoticeable, so we are
better off saving the 491880 bytes that these images consume.

BUG=691733
==========

to

==========
Android: Add exclude_xxxhdpi GN parameter to android_apk()

Plan to enable the flag in chrome_apk_tmpl in a follow-up.

BUG=691733
==========

[agrieve, 2017-06-22 14:32:50]

agrieve@chromium.org changed reviewers:
+ wnwen@chromium.org

[agrieve, 2017-06-22 14:33:16]

On 2017/06/22 14:32:50, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:wnwen@chromium.org

🎥

[agrieve, 2017-06-22 14:33:20]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 14:33:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 14:48:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 14:48:57]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)

[Peter Wen, 2017-06-22 15:00:00]

lgtm % comment

https://codereview.chromium.org/2948083003/diff/20001/build/android/gyp/packa...
File build/android/gyp/package_resources.py (right):

https://codereview.chromium.org/2948083003/diff/20001/build/android/gyp/packa...
build/android/gyp/package_resources.py:320: # Returns True for all
non-whitelisted, non-mipmap xxxhdpi.
s/True/False/?

Looks like it returns True for all non-xxxhdpi, or mipmap, or whitelisted hdpi.

Returns False for xxxhdpi and non-mipmap and non-whitelisted.

[agrieve, 2017-06-22 17:23:48]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-22 17:24:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 18:52:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-22 18:52:25]

Dry run: This issue passed the CQ dry run.

[agrieve, 2017-06-22 19:06:04]

https://codereview.chromium.org/2948083003/diff/20001/build/android/gyp/packa...
File build/android/gyp/package_resources.py (right):

https://codereview.chromium.org/2948083003/diff/20001/build/android/gyp/packa...
build/android/gyp/package_resources.py:320: # Returns True for all
non-whitelisted, non-mipmap xxxhdpi.
On 2017/06/22 15:00:00, Peter Wen wrote:
> s/True/False/?
> 
> Looks like it returns True for all non-xxxhdpi, or mipmap, or whitelisted
hdpi.
> 
> Returns False for xxxhdpi and non-mipmap and non-whitelisted.

Done.

[agrieve, 2017-06-22 19:10:08]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-06-22 19:10:08]

The patchset sent to the CQ was uploaded after l-g-t-m from wnwen@chromium.org
Link to the patchset: https://codereview.chromium.org/2948083003/#ps60001
(title: "Fix comment")

[commit-bot: I haz the power, 2017-06-22 19:10:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-22 19:13:30]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1498158608463170,
"parent_rev": "63ddedc4cd3f0a35990b14b618b5415d1a9baeba", "commit_rev":
"8843ff4c2a8bde44bf19dadb661f3b089aacc2e1"}

[commit-bot: I haz the power, 2017-06-22 19:13:43]

Description was changed from

==========
Android: Add exclude_xxxhdpi GN parameter to android_apk()

Plan to enable the flag in chrome_apk_tmpl in a follow-up.

BUG=691733
==========

to

==========
Android: Add exclude_xxxhdpi GN parameter to android_apk()

Plan to enable the flag in chrome_apk_tmpl in a follow-up.

BUG=691733

Review-Url: https://codereview.chromium.org/2948083003
Cr-Commit-Position: refs/heads/master@{#481619}
Committed:
https://chromium.googlesource.com/chromium/src/+/8843ff4c2a8bde44bf19dadb661f...
==========

[commit-bot: I haz the power, 2017-06-22 19:13:44]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/8843ff4c2a8bde44bf19dadb661f...