Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 2948083003: Android: Add exclude_xxxhdpi GN parameter to android_apk (Closed)
Patch Set: Fix comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/gyp/package_resources.py ('k') | build/config/android/rules.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Do not add any imports to non-//build directories here. 5 # Do not add any imports to non-//build directories here.
6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in. 6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in.
7 import("//build_overrides/build.gni") 7 import("//build_overrides/build.gni")
8 import("//build/config/android/config.gni") 8 import("//build/config/android/config.gni")
9 import("//build/config/dcheck_always_on.gni") 9 import("//build/config/dcheck_always_on.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 1692 matching lines...) Expand 10 before | Expand all | Expand 10 after
1703 } 1703 }
1704 if (defined(invoker.aapt_locale_whitelist)) { 1704 if (defined(invoker.aapt_locale_whitelist)) {
1705 args += [ "--locale-whitelist=${invoker.aapt_locale_whitelist}" ] 1705 args += [ "--locale-whitelist=${invoker.aapt_locale_whitelist}" ]
1706 } 1706 }
1707 if (defined(invoker.extensions_to_not_compress)) { 1707 if (defined(invoker.extensions_to_not_compress)) {
1708 args += [ 1708 args += [
1709 "--no-compress", 1709 "--no-compress",
1710 invoker.extensions_to_not_compress, 1710 invoker.extensions_to_not_compress,
1711 ] 1711 ]
1712 } 1712 }
1713 if (defined(invoker.exclude_xxxhdpi) && invoker.exclude_xxxhdpi) {
1714 args += [ "--exclude-xxxhdpi" ]
1715 if (defined(invoker.xxxhdpi_whitelist)) {
1716 args += [ "--xxxhdpi-whitelist=${invoker.xxxhdpi_whitelist}" ]
1717 }
1718 }
1713 } 1719 }
1714 } 1720 }
1715 1721
1716 _package_resources_target_name = "${target_name}__package_resources" 1722 _package_resources_target_name = "${target_name}__package_resources"
1717 package_resources_helper(_package_resources_target_name) { 1723 package_resources_helper(_package_resources_target_name) {
1718 forward_variables_from(invoker, 1724 forward_variables_from(invoker,
1719 [ 1725 [
1720 "aapt_locale_whitelist", 1726 "aapt_locale_whitelist",
1721 "alternative_android_sdk_jar", 1727 "alternative_android_sdk_jar",
1722 "android_aapt_path", 1728 "android_aapt_path",
1729 "exclude_xxxhdpi",
1723 "extensions_to_not_compress", 1730 "extensions_to_not_compress",
1731 "xxxhdpi_whitelist",
1724 ]) 1732 ])
1725 deps = _deps 1733 deps = _deps
1726 android_manifest = _android_manifest 1734 android_manifest = _android_manifest
1727 resource_packaged_apk_path = _resource_packaged_apk_path 1735 resource_packaged_apk_path = _resource_packaged_apk_path
1728 } 1736 }
1729 1737
1730 _generate_incremental_manifest_target_name = 1738 _generate_incremental_manifest_target_name =
1731 "${target_name}_incremental_generate_manifest" 1739 "${target_name}_incremental_generate_manifest"
1732 _incremental_android_manifest = 1740 _incremental_android_manifest =
1733 get_label_info(_generate_incremental_manifest_target_name, 1741 get_label_info(_generate_incremental_manifest_target_name,
(...skipping 28 matching lines...) Expand all
1762 "${target_name}_incremental__package_resources" 1770 "${target_name}_incremental__package_resources"
1763 1771
1764 # TODO(agrieve): See if we can speed up this step by swapping the manifest 1772 # TODO(agrieve): See if we can speed up this step by swapping the manifest
1765 # from the result of the main package_resources step. 1773 # from the result of the main package_resources step.
1766 package_resources_helper(_incremental_package_resources_target_name) { 1774 package_resources_helper(_incremental_package_resources_target_name) {
1767 forward_variables_from(invoker, 1775 forward_variables_from(invoker,
1768 [ 1776 [
1769 "aapt_locale_whitelist", 1777 "aapt_locale_whitelist",
1770 "alternative_android_sdk_jar", 1778 "alternative_android_sdk_jar",
1771 "android_aapt_path", 1779 "android_aapt_path",
1780 "exclude_xxxhdpi",
1772 "extensions_to_not_compress", 1781 "extensions_to_not_compress",
1782 "xxxhdpi_whitelist",
1773 ]) 1783 ])
1774 deps = 1784 deps =
1775 _incremental_deps + [ ":$_generate_incremental_manifest_target_name" ] 1785 _incremental_deps + [ ":$_generate_incremental_manifest_target_name" ]
1776 android_manifest = _incremental_android_manifest 1786 android_manifest = _incremental_android_manifest
1777 resource_packaged_apk_path = _incremental_resource_packaged_apk_path 1787 resource_packaged_apk_path = _incremental_resource_packaged_apk_path
1778 } 1788 }
1779 1789
1780 package_target = "${target_name}__package" 1790 package_target = "${target_name}__package"
1781 package_apk(package_target) { 1791 package_apk(package_target) {
1782 forward_variables_from(invoker, 1792 forward_variables_from(invoker,
(...skipping 1126 matching lines...) Expand 10 before | Expand all | Expand 10 after
2909 rebase_path(root_build_dir, root_build_dir), 2919 rebase_path(root_build_dir, root_build_dir),
2910 "--packed-libraries-dir", 2920 "--packed-libraries-dir",
2911 rebase_path(_packed_libraries_dir, root_build_dir), 2921 rebase_path(_packed_libraries_dir, root_build_dir),
2912 "--libraries=${invoker.libraries_filearg}", 2922 "--libraries=${invoker.libraries_filearg}",
2913 "--filelistjson", 2923 "--filelistjson",
2914 rebase_path(invoker.file_list_json, root_build_dir), 2924 rebase_path(invoker.file_list_json, root_build_dir),
2915 ] 2925 ]
2916 } 2926 }
2917 } 2927 }
2918 } 2928 }
OLDNEW
« no previous file with comments | « build/android/gyp/package_resources.py ('k') | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698