Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1062)

Issue 2947843003: WebVR: fix angular velocity calculation for headset (Closed)

Created:
3 years, 6 months ago by klausw
Modified:
3 years, 6 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org, Ian Vollick, bsheedy
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebVR: fix angular velocity calculation for headset The refactor https://chromium-review.googlesource.com/536475 lost a pair of parentheses, so the division by epsilon_seconds was just dividing one of the matrix elements instead of the difference. This broke angular velocity calculation. BUG=735155 Review-Url: https://codereview.chromium.org/2947843003 Cr-Commit-Position: refs/heads/master@{#480946} Committed: https://chromium.googlesource.com/chromium/src/+/455a29452a85a4de9603b0d4d99373930cb20bb3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M device/vr/android/gvr/gvr_delegate.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
klausw
3 years, 6 months ago (2017-06-20 19:25:12 UTC) #2
mthiesse
lgtm
3 years, 6 months ago (2017-06-20 19:33:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947843003/1
3 years, 6 months ago (2017-06-20 19:34:00 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-20 20:44:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/455a29452a85a4de9603b0d4d993...

Powered by Google App Engine
This is Rietveld 408576698