VM-codegen: Clean up the way we emit code for comparison instructions.

VM-codegen: Clean up the way we emit code for comparison instructions.

Removes some redundancy in the Emit* methods in intermediate_language_*.cc for
the 6 architectures we support.

This is a reapplication of https://codereview.chromium.org/2937933002/ -
see the comments there.  It fixes a bug in the way the TestCids
instruction was emitted on DBC.

R=vegorov@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/dfb67ecbf873e4423506d1f5f74ecc9b6aee0c05

[Vyacheslav Egorov (Google), 2017-06-19 13:41:21]

lgtm

https://codereview.chromium.org/2947633002/diff/20001/runtime/vm/intermediate...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2947633002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:575: __ LoadConstant(
maybe make a

const bool next_is_true = true_condition == NEXT_IS_TRUE;

and use it everywhere here?

(true_condition != INVALID_CONDITION here, so !next_is_true implies
true_condition == NEXT_IS_FALSE)

https://codereview.chromium.org/2947633002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:576: result, true_condition ==
NEXT_IS_TRUE ? Bool::False() : Bool::True());
__ LoadConstant(result, Bool::Get(!next_is_true));

https://codereview.chromium.org/2947633002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:588: __ LoadConstant(
__ LoadConstant(result, Bool::Get(next_is_true));

https://codereview.chromium.org/2947633002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:597: __ LoadConstant(result,
true_condition == NEXT_IS_TRUE ? Bool::False()
Bool::Get(!next_is_true)

[erikcorry, 2017-06-20 15:06:06]

https://codereview.chromium.org/2947633002/diff/20001/runtime/vm/intermediate...
File runtime/vm/intermediate_language_dbc.cc (right):

https://codereview.chromium.org/2947633002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:575: __ LoadConstant(
On 2017/06/19 13:41:20, Vyacheslav Egorov (Google) wrote:
> maybe make a
> 
> const bool next_is_true = true_condition == NEXT_IS_TRUE;
> 
> and use it everywhere here?
> 
> (true_condition != INVALID_CONDITION here, so !next_is_true implies
> true_condition == NEXT_IS_FALSE)

Done.

https://codereview.chromium.org/2947633002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:576: result, true_condition ==
NEXT_IS_TRUE ? Bool::False() : Bool::True());
On 2017/06/19 13:41:21, Vyacheslav Egorov (Google) wrote:
> __ LoadConstant(result, Bool::Get(!next_is_true));

Done.

https://codereview.chromium.org/2947633002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:588: __ LoadConstant(
On 2017/06/19 13:41:20, Vyacheslav Egorov (Google) wrote:
> __ LoadConstant(result, Bool::Get(next_is_true));

Done.

https://codereview.chromium.org/2947633002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language_dbc.cc:597: __ LoadConstant(result,
true_condition == NEXT_IS_TRUE ? Bool::False()
On 2017/06/19 13:41:20, Vyacheslav Egorov (Google) wrote:
> Bool::Get(!next_is_true)

Done.

[erikcorry, 2017-06-20 15:41:18]

Description was changed from

==========
VM-codegen: Clean up the way we emit code for comparison instructions.

Removes some redundancy in the Emit* methods in intermediate_language_*.cc for
the 6 architectures we support.

This is a reapplication of https://codereview.chromium.org/2937933002/ -
see the comments there.  It fixes a bug in the way the TestCids
instruction was emitted on DBC.

R=vegorov@google.com
BUG=
==========

to

==========
VM-codegen: Clean up the way we emit code for comparison instructions.

Removes some redundancy in the Emit* methods in intermediate_language_*.cc for
the 6 architectures we support.

This is a reapplication of https://codereview.chromium.org/2937933002/ -
see the comments there.  It fixes a bug in the way the TestCids
instruction was emitted on DBC.

R=vegorov@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/dfb67ecbf873e4423506d1f5f74ecc9b6aee0c05
==========

[erikcorry, 2017-06-20 15:41:20]

Committed patchset #3 (id:40001) manually as
dfb67ecbf873e4423506d1f5f74ecc9b6aee0c05 (presubmit successful).