runtime/vm/constants_dbc.h - Issue 2947633002: VM-codegen: Clean up the way we emit code for comparison instructions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constants_dbc.h

Issue 2947633002: VM-codegen: Clean up the way we emit code for comparison instructions. (Closed)

Patch Set: Simplify DBC ComparisonInstr::EmitNativeCode Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/constants_dbc.h

diff --git a/runtime/vm/constants_dbc.h b/runtime/vm/constants_dbc.h

index 5e843617e9108132ef7dcc691f04c2f9eec9acac..eb2b21fe107cbc1933b619c73145d087003af924 100644

--- a/runtime/vm/constants_dbc.h

+++ b/runtime/vm/constants_dbc.h

@@ -996,7 +996,7 @@ const intptr_t kNumberOfFpuRegisters = 1;

// instruction is executed if the comparison is true and skipped over overwise.

// Condition NEXT_IS_FALSE means the following instruction is executed if the

// comparison is false and skipped over otherwise.

-enum Condition { NEXT_IS_TRUE, NEXT_IS_FALSE };

+enum Condition { NEXT_IS_TRUE, NEXT_IS_FALSE, INVALID_CONDITION };

} // namespace dart

« no previous file with comments | « runtime/vm/constants_arm64.h ('k') | runtime/vm/constants_ia32.h » ('j') | no next file with comments »