Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2947593005: Use ContainsValue() instead of std::find() in chrome/browser/ui/ (Closed)

Created:
3 years, 6 months ago by Tripta
Modified:
3 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, michaelpg+watch-md-settings_chromium.org, hidehiko+watch_chromium.org, dcheng, rginda+watch_chromium.org, dougt+watch_chromium.org, lhchavez+watch_chromium.org, dmazzoni+watch_chromium.org, extensions-reviews_chromium.org, Matt Giuca, aboxhall+watch_chromium.org, je_julie, chromium-apps-reviews_chromium.org, victorhsieh+watch_chromium.org, yuzo+watch_chromium.org, aleventhal+watch_chromium.org, oshima+watch_chromium.org, kalyank, elijahtaylor+arcwatch_chromium.org, tfarina, nektar+watch_chromium.org, dtseng+watch_chromium.org, mac-reviews_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ContainsValue() instead of std::find() in chrome/browser/ui/ BUG=561800 Review-Url: https://codereview.chromium.org/2947593005 Cr-Commit-Position: refs/heads/master@{#482894} Committed: https://chromium.googlesource.com/chromium/src/+/5ad8596fe9db9ee109284e34b04fed309a0fc976

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
Tripta
Hi Sky, Please review code changes for below files: chrome/browser/ui/app_list/arc/arc_app_unittest.cc chrome/browser/ui/ash/launcher/multi_profile_browser_status_monitor.cc chrome/browser/ui/aura/accessibility/ax_root_obj_wrapper.cc chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm ...
3 years, 6 months ago (2017-06-20 08:24:00 UTC) #3
Tripta
Please review the code changes
3 years, 5 months ago (2017-06-27 06:44:43 UTC) #4
sky
LGTM
3 years, 5 months ago (2017-06-27 18:17:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2947593005/1
3 years, 5 months ago (2017-06-28 04:21:46 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 05:27:30 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ad8596fe9db9ee109284e34b04f...

Powered by Google App Engine
This is Rietveld 408576698