Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

Issue 2947593005: Use ContainsValue() instead of std::find() in chrome/browser/ui/ (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm
index f75b0b4b1353e83e52f8887eb8585a2a948486cd..4bac07311ddfd23dd9f1d68c099fc02c1f63cc0b 100644
--- a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm
@@ -10,6 +10,7 @@
#include "base/mac/foundation_util.h"
#include "base/mac/scoped_nsobject.h"
+#include "base/stl_util.h"
#include "base/strings/string16.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
@@ -171,10 +172,8 @@ TEST_F(AccountChooserViewControllerTest, ForwardsAvatarFetchToManager) {
local_forms.push_back(std::move(form));
SetUpAccountChooser(&local_forms);
EXPECT_FALSE(avatar_manager().fetchedAvatars.empty());
- EXPECT_TRUE(std::find(avatar_manager().fetchedAvatars.begin(),
- avatar_manager().fetchedAvatars.end(),
- GURL("http://foo.com")) !=
- avatar_manager().fetchedAvatars.end());
+ EXPECT_TRUE(base::ContainsValue(avatar_manager().fetchedAvatars,
+ GURL("http://foo.com")));
}
TEST_F(AccountChooserViewControllerTest,

Powered by Google App Engine
This is Rietveld 408576698