chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm - Issue 2947593005: Use ContainsValue() instead of std::find() in chrome/browser/ui/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

Issue 2947593005: Use ContainsValue() instead of std::find() in chrome/browser/ui/ (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm ('k') | chrome/browser/ui/input_method/input_method_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

index f75b0b4b1353e83e52f8887eb8585a2a948486cd..4bac07311ddfd23dd9f1d68c099fc02c1f63cc0b 100644

--- a/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm

@@ -10,6 +10,7 @@

#include "base/mac/foundation_util.h"

#include "base/mac/scoped_nsobject.h"

+#include "base/stl_util.h"

#include "base/strings/string16.h"

#include "base/strings/sys_string_conversions.h"

#include "base/strings/utf_string_conversions.h"

@@ -171,10 +172,8 @@ TEST_F(AccountChooserViewControllerTest, ForwardsAvatarFetchToManager) {

local_forms.push_back(std::move(form));

SetUpAccountChooser(&local_forms);

EXPECT_FALSE(avatar_manager().fetchedAvatars.empty());

- EXPECT_TRUE(std::find(avatar_manager().fetchedAvatars.begin(),

- avatar_manager().fetchedAvatars.end(),

- GURL("http://foo.com")) !=

- avatar_manager().fetchedAvatars.end());

+ EXPECT_TRUE(base::ContainsValue(avatar_manager().fetchedAvatars,

+ GURL("http://foo.com")));

}

TEST_F(AccountChooserViewControllerTest,